Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P3A: command line option to dismiss/hide prompt #17143

Open
phanirithvij opened this issue Jul 24, 2021 · 0 comments
Open

P3A: command line option to dismiss/hide prompt #17143

phanirithvij opened this issue Jul 24, 2021 · 0 comments
Labels
features/P3A OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
P3A

Comments

@phanirithvij
Copy link

phanirithvij commented Jul 24, 2021 •
edited

As of now, there is no command-line option (documented anywhere) on how to disable this prompt by either enabling or disabling it via cli.

image

This commit removed a switch that might be related. --p3a-upload-enabled
brave/brave-core@c183adb

I think it is this the pref brave.p3a.notice_acknowledged defined in https://github.com/brave/brave-core/blob/master/components/p3a/pref_names.cc#L11

This is a major issue when using brave with Chrome Devtools Protocol.
One such project which uses it has every new run prompt the notice, https://github.com/zserge/lorca.
@rebron rebron added features/P3A priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
features/P3A OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
P3A
  
Awaiting triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rebron @phanirithvij