Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saved bookmark in bookmark dialog not centered #17238

Open
lazymonkey2 opened this issue Jul 29, 2021 · 2 comments
Open

saved bookmark in bookmark dialog not centered #17238

lazymonkey2 opened this issue Jul 29, 2021 · 2 comments
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/bookmarks OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. repros-on-chrome
Projects

Comments

@lazymonkey2
Copy link

Description

when I open the bookmark dialog for a bookmark already saved the dialog shows bookmarks starting from the top of collection,
instead it should be centered on the folder containing the saved bookmark.

Steps to Reproduce

  1. create enough folders so that a scrollbar appears on bookmarks dialog (16 or more)
  2. bookmark a page in a folder at the bottom of bookmarks collection
  3. load the page
  4. click on the black bookmark button on the left of the url bar (to modify the bookmark)
  5. click on other... button to see other folders

Actual result:

the dialog opens showing the bookmark folders at the top

Expected result:

the dialog opens showing the folder containing the already saved bookmark.

Reproduces how often:

always

Brave version (brave://version info)

Versione 1.27.109 Chromium: 92.0.4515.115 (Build ufficiale) (a 64 bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron
Copy link
Collaborator

rebron commented Jul 29, 2021

@Tortino Can you post a screenshot when you get a chance?

@rebron rebron added feature/bookmarks needs-more-info The report requires more detail before we can decide what to do with this issue. labels Jul 29, 2021
@lazymonkey2
Copy link
Author

Here are the screenshots.

image

When the modify bookmark dialog is opened it always starts at the top of my bookmarks collection (the folder containing my bookmark is not visibile, and I have to scroll and search for it).

image

Instead the modify dialog should be automatically centered on the folder containing the bookmark that I'm modifying (if needed it should scroll down):

image

@rebron rebron added this to Untriaged backlog in Front End Aug 3, 2021
@rebron rebron added Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix repros-on-chrome priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed needs-more-info The report requires more detail before we can decide what to do with this issue. labels Mar 16, 2022
@rebron rebron moved this from Untriaged backlog to P5 backlog in Front End Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix feature/bookmarks OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. repros-on-chrome
Projects
Status: P5 backlog
Front End
  
P5 backlog
Development

No branches or pull requests

2 participants