Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shields to show background accent colour for count, label, info icon, and share icon #17312

Open
srirambv opened this issue Aug 3, 2021 · 0 comments
Open

Update shields to show background accent colour for count, label, info icon, and share icon #17312

srirambv opened this issue Aug 3, 2021 · 0 comments
Assignees
@alexsafe
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Shields Android General

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 3, 2021

Description

Update shields to show background accent colour for count, label, info icon, and share icon

Actual result

image

Expected result

image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet):All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @karenkliu @deeppandya @alexsafe
@srirambv srirambv added QA/Yes release-notes/include feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality labels Aug 3, 2021
@srirambv srirambv added this to Untriaged / Incoming in Shields via automation Aug 3, 2021
@srirambv srirambv mentioned this issue Aug 3, 2021
Closed
@rebron rebron added this to Untriaged Backlog in General Aug 3, 2021
@rebron rebron added this to Backlog in Android General via automation Aug 10, 2021
@rebron rebron removed this from Untriaged Backlog in General Aug 10, 2021
@anthonypkeane anthonypkeane moved this from Backlog to P3 in Android General Sep 1, 2021
@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexsafe alexsafe

Labels
feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Android General
  
P3
Shields
  
Untriaged / Incoming
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexsafe @anthonypkeane @srirambv