Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing site-specific fingerprinting blocking setting to strict mode prevents switching to standard mode #17447

Open
dentistformyeye opened this issue Aug 11, 2021 · 1 comment
Assignees
Labels
bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality

Comments

@dentistformyeye
Copy link

dentistformyeye commented Aug 11, 2021

Description

After changing the site-specific fingerprinting setting in Brave Shields to strict mode, attempting to set the fingerprinting setting to standard mode fails; the setting stays on strict mode. This might be related to #15288.
(Changing the setting to "Allow all fingerprinting" works, but changing the setting to standard blocking afterward still causes the setting to switch to strict mode.)

Steps to reproduce

  1. Go to https://brave.com/
  2. Tap the Brave Shields icon, Advanced controls, and Block Fingerprinting. Tap "Fingerprinting blocked (strict, may break sites)". Tap Done.
  3. Repeat step 2, but choose "Fingerprinting blocked (standard)" instead of the strict option.

Actual result

The fingerprinting setting is still set to the strict option.

Expected result

The fingerprinting setting is set to the standard option.

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Haven't tried
  • Can you reproduce this issue with the current Play Store Nightly version? Haven't tried

Device details

  • Install type (ARM, x86): Uncertain; probably ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 6.0.1

Brave version

1.27.111 (Chromium: 92.0.4515.131)

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@dentistformyeye dentistformyeye added the OS/Android Fixes related to Android browser functionality label Aug 11, 2021
@Tonev
Copy link
Contributor

Tonev commented Aug 12, 2021

Reproduced the issue on my end as well.

Users can still use Standard fingerprinting protection but for that they'll have to clear Site settings, which will reset global Brave Shields settings along with all site-specific Brave Shields settings. Once Site settings have been cleared, setting Standard fingerprinting protection on a global level will result in Standard fingerprinting protection for all websites. That's if users have made any site-specific Brave Shields changes, otherwise global Brave Shields settings are still applied properly.

@bsclifton bsclifton added bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields labels Jul 28, 2022
@deeppandya deeppandya self-assigned this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

4 participants