Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous that in empty-history text #20867

Open
stephendonner opened this issue Feb 3, 2022 · 2 comments
Open

Remove extraneous that in empty-history text #20867

stephendonner opened this issue Feb 3, 2022 · 2 comments
Labels
needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality QA/Yes

Comments

@stephendonner
Copy link

Description

Remove extraneous that in empty-history text

Steps to reproduce

  1. install Brave 1.37.22, Chromium 98.0.4758.87
  2. launch Brave
  3. tap through onboarding
  4. tap on the 3-dots menu on the bottom toolbar
  5. tap on Settings
  6. tap on History
  7. read the descriptive text

Actual result

Pages that you visit appear here

Screenshot_20220202-235719

Expected result

Pages you visit appear here or similar (remove that)

Desktop:
Screen Shot 2022-02-02 at 11 59 40 PM

Issue reproduces how often

100%

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? yes
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Google Pixel XL phone
  • Android version: 9.0.

Brave version

1.37.22, Chromium 98.0.4758.87

cc @rmcfadden3

@stephendonner stephendonner added needs-text-change This change requires some careful wording. QA/Yes OS/Android Fixes related to Android browser functionality labels Feb 3, 2022
@rmcfadden3
Copy link

@stephendonner — yeah, good flag. I'm down to remove the "that" from this string. Agree it's not needed.

@stephendonner
Copy link
Author

This is also present in the Bookmarks window; not sure if whomever fixes this wants to address that here or in a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants