Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide all unsupported test networks along with custom networks for Swap screens #21039

Closed
srirambv opened this issue Feb 11, 2022 · 2 comments
Closed
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

brave/brave-core#12204 fixed hiding custom EVM's which are added where Buy & Swap is unsupported. Similarly we should hide test networks for Swap as its only allowed on Mainnet and Ropsten

Steps to reproduce

  1. Open Swap screen
  2. Select Network dropdown
  3. Able to select unsupported test networks

Actual result

Unsupported.Swap.Network.mp4

Expected result

Should hide unsupported test networks

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @SergeyZhukovsky @Pavneet-Sing

@srirambv srirambv added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 11, 2022
@srirambv srirambv added this to Backlog in Android General via automation Feb 11, 2022
@srirambv srirambv added this to Untriaged in Wallet via automation Feb 11, 2022
@muliswilliam muliswilliam self-assigned this Feb 17, 2022
@muliswilliam muliswilliam moved this from Untriaged to In progress in Wallet Feb 17, 2022
@muliswilliam muliswilliam added this to the 1.37.x - Nightly milestone Feb 17, 2022
@muliswilliam muliswilliam removed their assignment Feb 17, 2022
@muliswilliam muliswilliam moved this from In progress to Untriaged in Wallet Feb 17, 2022
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Feb 25, 2022
@bbondy bbondy moved this from Untriaged to Backlog in Wallet Feb 25, 2022
@bbondy bbondy removed this from Backlog in Wallet Mar 18, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 23, 2022

Removing this from the 1.37.x milestone as this hasn't been labelled as release/blocking nor has it been finished as it's still in the backlog. Please see https://github.com/brave/brave-browser/wiki/Triage-Guidelines 👍

@kjozwiak kjozwiak removed this from the 1.37.x - Release milestone Mar 23, 2022
@Pavneet-Sing
Copy link

Closing as "no longer valid".

Android General automation moved this from Backlog to Done/Closed Jan 30, 2023
@Pavneet-Sing Pavneet-Sing added this to the Closed / Dupe / Invalid milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude
Projects
Android General
  
Done/Closed
Archived in project
Development

No branches or pull requests

5 participants