Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max fee is not updated when base fee changes #21105

Closed
onyb opened this issue Feb 15, 2022 · 2 comments
Closed

Max fee is not updated when base fee changes #21105

onyb opened this issue Feb 15, 2022 · 2 comments
Assignees
@onyb
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@onyb
Copy link
Member

onyb commented Feb 15, 2022 •
edited
Loading

Steps to reproduce:

  1. Create an EIP-1559 transaction and open the "Edit gas" screen.
    Screenshot 2022-02-15 at 6 12 00 PM
  2. Select "Custom gas".
  3. Wait for the base fee to change.
  4. Expected behaviour: the max fee also changes in response to change in base fee.

This is only reproducible on 1.36.x or earlier.
@onyb onyb self-assigned this Feb 15, 2022
@onyb onyb added the bug label Feb 15, 2022
@onyb onyb added this to Untriaged in Wallet via automation Feb 15, 2022
@onyb onyb moved this from Untriaged to In Review in Wallet Feb 15, 2022
@onyb onyb added feature/web3/wallet Integrating Ethereum+ wallet support QA/Yes release-notes/include labels Feb 15, 2022
@onyb onyb mentioned this issue Feb 15, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

Closing as brave/brave-core#12264 was merged into 1.36.x.

Wallet automation moved this from In Review to Closed Feb 17, 2022
@kjozwiak kjozwiak added this to the 1.36.x - Beta milestone Feb 17, 2022
@srirambv
Copy link
Contributor

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#12264
  • Verified the base fee updates every 15 secs
  • Verified Per-gas price limit updates as and when base fee updates
  • Verified suggested fee is also showing correct values
21105-Linux.mp4
21105-Windows.mov
21105-macOS.mov

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@bbondy bbondy removed this from Closed in Wallet Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

No branches or pull requests
3 participants
@kjozwiak @onyb @srirambv