Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CoingecoID should only show the value for the selected asset rather than at portfolio #21217

Closed
srirambv opened this issue Feb 21, 2022 · 1 comment

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 21, 2022

Description

Adding CoingecoID should only show the value for the selected asset rather than at portfolio. Found while testing #20581

Steps to Reproduce

  1. Add a custom asset view
  2. Add bitcoin for CoingeckoID in the custom asset details
  3. Entire portfolio and other existing tokens values are listed in BTC value rather than the one that is added

Actual result:

Adding CoingecoID should only show the value for the selected asset rather than at portfolio
Screen Shot 2022-02-21 at 8 41 44 AM

Expected result:

Should only show for the custom token that is added

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (x86_64 translated)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @onyb

@srirambv srirambv added bug QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Feb 21, 2022
@srirambv srirambv added this to Untriaged in Wallet via automation Feb 21, 2022
@Douglashdaniel
Copy link

Per internal discussion this is expected behavior.
CoingeckoID is for used for getting the accurate price for a token and was added as an option since symbols don't always return the correct price information from our API.
Adding Bitcoin as a CoingeckoID is going to reflect as the price for that token.

Wallet automation moved this from Untriaged to Closed Feb 22, 2022
@bbondy bbondy removed this from Closed in Wallet Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants