Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when trying to submit IPFS gateway address #21479

Closed
stephendonner opened this issue Mar 4, 2022 · 3 comments
Closed

TypeError when trying to submit IPFS gateway address #21479

stephendonner opened this issue Mar 4, 2022 · 3 comments
Labels
bug closed/duplicate Issue has already been reported feature/web3/ipfs OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA/Test-Plan-Specified
Projects

Comments

@stephendonner
Copy link

Description

TypeError when trying to submit IPFS gateway address

Steps to Reproduce

  1. install 1.38.23
  2. launch Brave
  3. open brave://settings/ipfs
  4. click on the Change button on IPFS Public Gateway Address
  5. enter https://infura-ipfs.io
  6. click Submit
  7. look in the JS console for errors

Actual result:

Nothing happens

settings.js:406 Uncaught (in promise) TypeError: this.fire is not a function
    at settings.js:406:500

Screen Shot 2022-03-04 at 12 38 43 PM

Expected result:

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.38.23 Chromium: 99.0.4844.51 (Official Build) nightly (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 11.6.3 (Build 20G415)

cc @spylogsster @lidel @MadhaviSeelam

@stephendonner
Copy link
Author

@spylogsster I ran into this on 1.36.109 - can you please take a look when you get a chance? Thanks!

@srirambv
Copy link
Contributor

srirambv commented Dec 5, 2022

This seems to be fixed. I don't see any errors in console. Just error about Origin isolation error when trying to add.

@stephendonner
Copy link
Author

This seems to be fixed. I don't see any errors in console. Just error about Origin isolation error when trying to add.

This was fixed by #26104. I'll mark it a duplicate.

IPFS automation moved this from Untriaged to Done Dec 11, 2022
@stephendonner stephendonner added closed/duplicate Issue has already been reported QA/No and removed QA/Yes labels Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/duplicate Issue has already been reported feature/web3/ipfs OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA/Test-Plan-Specified
Projects
IPFS
  
Done
Development

No branches or pull requests

3 participants