Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Check not working on many sites and fields #22195

Closed
rahulraj80 opened this issue Apr 10, 2022 · 9 comments
Closed

Spell Check not working on many sites and fields #22195

rahulraj80 opened this issue Apr 10, 2022 · 9 comments
Labels
closed/by-author feature/spell-check needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P4 Planned work. We expect to get to it "soon". webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@rahulraj80
Copy link

rahulraj80 commented Apr 10, 2022

Description

Spell check works on some text fields and does not work on others. It used to work on Discord but has stopped working recently.

Steps to Reproduce

  1. Spell Chekc works in the text box being used to raise the bug report, and also in the fields like Subject and Filter but it does not work in the search field on top left of Github, and does not work (any more) in the chat fields in Discord

  2. I have tried changing between English (US) and English (UK) as well.

  3. Cleared cache on websites and disabled all extensions. Did not help.

Actual result:

Attaching screenshots to show where a typo like "Chekc" had been caught and not caught.

Image1 - Issues and Bugs - Filter : Spell Check is working
image

Image2 - Bug filing edit box : Spell Check is working:
image

Image3 - Search box on top left of Github : Spell Check NOT working
image

Image4 - Message box of Discord (web) : Spell Check NOT working
image

Expected result:

Spelling errors should be highlighted.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.37.111 Chromium: 100.0.4896.79 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? YES
  • Can you reproduce this issue with the beta channel? Don't have access
  • Can you reproduce this issue with the nightly channel? Don't have access

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Don't have Chrome

Miscellaneous Information:

@rebron rebron added feature/spell-check priority/P4 Planned work. We expect to get to it "soon". labels Apr 11, 2022
@rebron
Copy link
Collaborator

rebron commented Apr 11, 2022

Looks like this maybe specific to discord as there are other reports of spell check no longer working there. Some places with github may set spell check to be set as false so it won't show up.

@rebron rebron added webcompat/not-shields-related Sites are breaking because of something other than Shields. needs-investigation A bug not 100% confirmed/fixed labels Apr 11, 2022
@rahulraj80
Copy link
Author

rahulraj80 commented Apr 12, 2022

@rebron :

Thanks for the hint - that made me look at it again.

I did not have Chrome to check, but I had MS-Edge and Opera.

The surprising thing is that Discord chat textbox shows up with spellcheck="true" on both Opera and MS-Edge, but on Brave, that field shows up as spellcheck="false". I tested in In-Private mode with all extensions disabled as well. Any idea why that might be - is Brave being specifically crippled by Discord? Spellcheck was a feature according to them.

Brave (autocorrect="false" spellcheck="false") :
image

<div role="textbox" spellcheck="false" aria-haspopup="listbox" aria-invalid="false" aria-autocomplete="list" class="markup-eYLPri editor-H2NA06 slateTextArea-27tjG0 fontSize16Padding-XoMpjI" autocorrect="false" data-can-focus="true" aria-label="Message #😺chatter-box" aria-multiline="true" autocapitalize="false" data-slate-editor="true" data-slate-node="value" contenteditable="true" zindex="-1" style="position: relative; outline: none; white-space: pre-wrap; overflow-wrap: break-word;"><div data-slate-node="element"><span data-slate-node="text"><span data-slate-leaf="true" class="emptyText-1o0WH_"><span data-slate-zero-width="n" data-slate-length="0"><br></span></span></span></div></div>

MS-Edge (autocorrect="off" spellcheck="true") :
image

<div aria-haspopup="listbox" aria-autocomplete="list" aria-label="Message #😺chatter-box" aria-multiline="true" data-can-focus="true" data-slate-editor="true" data-key="66" contenteditable="true" class="markup-eYLPri slateTextArea-27tjG0 fontSize16Padding-XoMpjI" autocorrect="off" spellcheck="true" role="textbox" data-gramm="false" style="outline: none; white-space: pre-wrap; overflow-wrap: break-word; -webkit-user-modify: read-write-plaintext-only;"><div data-slate-object="block" data-key="67" style="position: relative;"><span data-slate-object="text" data-key="68"><span data-slate-leaf="true" data-offset-key="68:0"><span data-slate-zero-width="z" data-slate-length="0"><br></span></span></span></div></div>

Opera (autocorrect="off" spellcheck="false") :
image

<div role="textbox" spellcheck="true" aria-haspopup="listbox" aria-invalid="false" aria-autocomplete="list" class="markup-eYLPri editor-H2NA06 slateTextArea-27tjG0 fontSize16Padding-XoMpjI" autocorrect="off" data-can-focus="true" aria-label="Message #😺chatter-box" aria-multiline="true" data-slate-editor="true" data-slate-node="value" contenteditable="true" zindex="-1" style="position: relative; outline: none; white-space: pre-wrap; overflow-wrap: break-word;"><div data-slate-node="element"><span data-slate-node="text"><span data-slate-leaf="true" class="emptyText-1o0WH_"><span data-slate-zero-width="n" data-slate-length="0"><br></span></span></span></div></div>

These are the fields which are not the same in all three browsers - I copied the elements from the three browsers and aligned them by fields:

`

<style> </style>
Brave MS-Edge Opera
aria-invalid="false"   aria-invalid="false"
autocapitalize="false"    
autocorrect="false" autocorrect="off" autocorrect="off"
  data-gramm="false"  
  data-key="66"  
data-slate-node="value"   data-slate-node="value"
editor-H2NA06   editor-H2NA06
spellcheck="false" spellcheck="true" spellcheck="true"
zindex="-1"   zindex="-1"
position:relative   position:relative
  -webkit-user-modify:read-write-plaintext-only  
data-slate-node="element"><span   data-slate-node="element"><span
data-slate-node="text"><span   data-slate-node="text"><span
data-slate-leaf="true"   data-slate-leaf="true"
class="emptyText-1o0WH_"><span   class="emptyText-1o0WH_"><span
  data-slate-object="block"  
  data-key="67"  
  style="position:  
  relative;"><span  
  data-slate-object="text"  
  data-key="68"><span  
  data-slate-leaf="true"  
  data-offset-key="68:0"><span  
data-slate-zero-width="n" data-slate-zero-width="z" data-slate-zero-width="n"

`

Is there any way for us to control it? Or is it something Discord alone can fix?

@rebron rebron added this to Untriaged Backlog in General Apr 12, 2022
@rebron
Copy link
Collaborator

rebron commented Apr 12, 2022

cc: @ryanbr Can you take a look? Is Discord detecting and blocking Brave on purpose? Something we can fix via filter lists?

@rebron rebron moved this from Untriaged Backlog to P4 Backlog in General Apr 12, 2022
@ryanbr
Copy link

ryanbr commented Apr 13, 2022

Need more info on replicating how this is done @rahulraj80 , below is screenshots from Chrome and Edge, with misspellings in the text fields. Neither of them corrected, or even highlighted the incorrect spellings.

discordd

@rahulraj80
Copy link
Author

@ryanbr :

This seems very strange!! Even for me MS-Edge today shows spellcheck="false" - it was definitely different earlier (refer old screenshots).

On Opera, this is still showing as spellcheck="true". Any chance you can check/confirm that? Or is there some magic happening on my machine that I don't know about!? 🤦 :-)

@ryanbr
Copy link

ryanbr commented Apr 13, 2022

Feels like a discord issue so far, does it occur only on discord? How about in Github comments? Does Brave spellcheck work here? @rahulraj80

@rahulraj80
Copy link
Author

rahulraj80 commented Apr 13, 2022

@ryanbr :

Yes : On Github, the relevant fields have spellcheck="true".

I had mentioned in the first post, that it does not work in the search field on top left, and it was pointed out to me that, that particular field has spellcheck="false".

The unusual behaviour I see is that on Opera, Discord shows the same fields with spellcheck enabled, unlike the other browsers.

I have not come across another site which chooses which browsers can have spellcheck enabled.

Is there some way for the users to use the internal scripting engine to define their own 'userscripts' in Brave without installing an extension. I am testing ViolentMonkey meanwhile but would be awesome if I can do it without an extension.

@ryanbr
Copy link

ryanbr commented Apr 13, 2022

Not currently, userJS like violentmonkey is the best bet here. We wouldn't change the defaults of a website regarding the spellcheck.

@rahulraj80
Copy link
Author

rahulraj80 commented Apr 13, 2022

Makes sense.

I have uploaded the script on [OpenUserJS : https://openuserjs.org/scripts/rahuraj80/Discord_SpellCheck] (https://openuserjs.org/scripts/rahuraj80/Discord_SpellCheck) for anyone who runs into the same issue. You can search for Discord Spell Check, or navigate using the URL

Also attached as an attachment with this post.

IMP: Remove the .txt extension before importing it in TamperMonkey - the extension should be user.js for TamperMonkey to accept it.

This can be installed using the TamperMonkey extension for Chromium based browsers.

With a slight modification in the wildcard parameters in the @match section, and the class name of the field to be modified, it can be used for any website, where you need to enable Spellcheck.

Closing this report given this seems to be a Discord issue.

------------------------------Attachment---------------------------------
Enable_SpellCheck_Discord.user.js.txt

General automation moved this from P4 Backlog to Completed Apr 13, 2022
@rebron rebron removed this from Completed in General May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/by-author feature/spell-check needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P4 Planned work. We expect to get to it "soon". webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

No branches or pull requests

4 participants