Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields should be disabled for magnet links #22428

Closed
Tracked by #22546
stephendonner opened this issue Apr 20, 2022 · 2 comments
Closed
Tracked by #22546

Shields should be disabled for magnet links #22428

stephendonner opened this issue Apr 20, 2022 · 2 comments
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.41.x - Release

Comments

@stephendonner
Copy link

Description

Shields should be disabled for magnet links

Steps to Reproduce

  1. install 1.39.33
  2. launch Brave
  3. load https://webtorrent.io/free-torrents
  4. click on (magnet link) for any file (such as magnet:?xt=urn:btih:dd8255ecdc7ca55fb0bbf81323d87062db1f6d1c&dn=Big+Buck+Bunny&tr=udp%3A%2F%2Fexplodie.org%3A6969&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969&tr=udp%3A%2F%2Ftracker.empire-js.us%3A1337&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337&tr=wss%3A%2F%2Ftracker.btorrent.xyz&tr=wss%3A%2F%2Ftracker.fastcast.nz&tr=wss%3A%2F%2Ftracker.openwebtorrent.com&ws=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2F&xs=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2Fbig-buck-bunny.torrent for Big Buck Bunny)
  5. reload the page (to work around a long-standing issue)
  6. examine/click on the Shields icon

Actual result:

It appears toggleable, but doesn't really do anything, nor correctly reflect its state.

Screen Shot 2022-04-20 at 11 01 08 AM

Expected result:

Shields should be disabled (if we are looking for parity with current release).

Screen Shot 2022-04-20 at 11 00 50 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.39.73 Chromium: 101.0.4951.34 (Official Build) nightly (x86_64)
Revision 8f93af5d759634c5256b65997dedd138ed60992f-refs/branch-heads/4951@{#710}
OS macOS Version 11.6.5 (Build 20G527)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @nullhook @rebron @GeetaSarvadnya @MadhaviSeelam
@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. QA/Yes QA/Test-Plan-Specified regression feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Apr 20, 2022
@stephendonner stephendonner added this to Untriaged / Incoming in Shields via automation Apr 20, 2022
@stephendonner stephendonner mentioned this issue Apr 23, 2022
Closed
3 tasks
@rebron rebron mentioned this issue Apr 25, 2022
Closed
7 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 26, 2022
@rebron rebron removed this from Untriaged / Incoming in Shields Apr 26, 2022
@rebron rebron added this to P3 Backlog in General May 10, 2022
@rebron rebron moved this from P3 Backlog to In progress in General May 10, 2022
@rebron rebron moved this from In progress to P3 Backlog in General May 20, 2022
@rebron
Copy link
Collaborator

rebron commented Jun 1, 2022

Closed with brave/brave-core#13209

@rebron rebron closed this as completed Jun 1, 2022
General automation moved this from P3 Backlog to Completed Jun 1, 2022
@rebron rebron added this to the 1.41.x - Nightly milestone Jun 1, 2022
@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.41.47 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS macOS Version 12.5 (Build 21G5037d)

Steps

  1. installed 1.41.47
  2. launched Brave
  3. loaded `https://webtorrent.io/free-torrents
  4. click on (magnet link) for any file (such as magnet:?xt=urn:btih:dd8255ecdc7ca55fb0bbf81323d87062db1f6d1c&dn=Big+Buck+Bunny&tr=udp%3A%2F%2Fexplodie.org%3A6969&tr=udp%3A%2F%2Ftracker.coppersurfer.tk%3A6969&tr=udp%3A%2F%2Ftracker.empire-js.us%3A1337&tr=udp%3A%2F%2Ftracker.leechers-paradise.org%3A6969&tr=udp%3A%2F%2Ftracker.opentrackr.org%3A1337&tr=wss%3A%2F%2Ftracker.btorrent.xyz&tr=wss%3A%2F%2Ftracker.fastcast.nz&tr=wss%3A%2F%2Ftracker.openwebtorrent.com&ws=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2F&xs=https%3A%2F%2Fwebtorrent.io%2Ftorrents%2Fbig-buck-bunny.torrent` for Big Buck Bunny)
    reload the page (to work around a long-standing issue)
    examine/click on the Shields icon

Confirmed the Shields icon is:

  1. default disabled when on a magnet URI
  2. not enableable

Screen Shot 2022-06-09 at 2 20 38 AM

@rebron rebron removed this from Completed in General Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.41.x - Release
Development

No branches or pull requests
2 participants
@stephendonner @rebron