Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards panel doesn't show creator publisher specific information for Vimeo #22832

Closed
elizabethlexi2000 opened this issue May 13, 2022 · 12 comments · Fixed by brave/brave-site-specific-scripts#79

Comments

@elizabethlexi2000
Copy link

elizabethlexi2000 commented May 13, 2022

Description

Same as previously solved issue; #11840

Rewards panel does not show creator specific information for vimeo publishers. Subsequently, you are unable to tip specific Vimeo publishers as well.

Steps to Reproduce

  1. Clean Profile
  2. Enable Rewards, wait for publisher list indexes to be downloaded
  3. Visit a vimeo page (ex. vimeo.com/bravelaurenwags on staging)

Actual result:

Vimeo publisher info is not shown in panel.
vimeo bug
In the above, it should say "Lauren on Vimeo" (or similar)
Additionally, choosing one of the tip buttons does not bring up the publisher's banner, but shows the generic banner for a non-verified publisher.

Expected result:

Vimeo publisher info should be shown in the panel.

Reproduces how often:

Easily

Brave version (brave://version info)

1.38x

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Yes

Miscellaneous Information:

@elizabethlexi2000
Copy link
Author

@LaurenWags

@LaurenWags
Copy link
Member

LaurenWags commented May 13, 2022

@elizabethlexi2000 if you click on "Refresh Status" does that fix it?

If not, try a restart. Could be that #6851 also applies to Vimeo publishers as well as Twitch.

@elizabethlexi2000
Copy link
Author

@LaurenWags Hi, unfortunately not. Rereshing the status, as well as the browser does not fix the issue.

I've also tried on a different PC with the same result. Is verification present on your end?

@LaurenWags
Copy link
Member

LaurenWags commented May 13, 2022

Thanks @elizabethlexi2000 - I am able to reproduce also.

cc @Miyayes @szilardszaloki @emerick - wonder if something changed and Greaselion can't get the needed info?

@elizabethlexi2000
Copy link
Author

elizabethlexi2000 commented May 14, 2022

@LaurenWags Thank you for confirming the bug. I presume this means that Vimeo creators cannot receive any tips until the issue is resolved?
cc @Miyayes @szilardszaloki @emerick

@Miyayes
Copy link
Collaborator

Miyayes commented May 16, 2022

Doesn't repro for https://vimeo.com/user7039569, but does repro for https://vimeo.com/bravelaurenwags.

@Miyayes Miyayes added this to New Issues in Brave Rewards via automation May 16, 2022
@elizabethlexi2000
Copy link
Author

elizabethlexi2000 commented May 16, 2022

Hi @Miyayes, Thanks for the reply. The screenshot was taken from an older vimeo issue #11840. But I have now edited the post to reflect the 1.38x screenshot. As you have stated, it likewise doesn't repro for https://vimeo.com/user7039569, but does for https://vimeo.com/bravelaurenwags as well as other vimeo creators.

The issue also affects the Auto-contribute list that populates in the Rewards page. The affected verified creators are not added to the auto-contribute list regardless of time spent on their channel page.

@Miyayes
Copy link
Collaborator

Miyayes commented May 18, 2022

Something might've changed in the Vimeo DOM (zenparsing)

@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 18, 2022
@Miyayes Miyayes moved this from New Issues to Backlog in Brave Rewards May 25, 2022
@emerick
Copy link
Contributor

emerick commented Jun 8, 2022

It does seem like something changed in the Vimeo DOM. From what I can tell, it seems to affect users who have customized their Vimeo URL (so bravelaurenwags vs user12345). Unfortunately, what we get back from Vimeo in the former case doesn't contain the publisher name anywhere ("Lauren Wagner" in this case). Perhaps we should just show the user ID (bravelaurenwags) in this case rather than failing out completely.

@elizabethlexi2000
Copy link
Author

Hi @emerick, It appears, at least on my end, that the original functionality has been mostly restored. Previously bugged Vimeo creators with custom URLs are now displaying verified again. Such as these below;
https://vimeo.com/danelder
https://vimeo.com/hscottroth
https://vimeo.com/ericnathan

Curiously, https://vimeo.com/bravelaurenwags remains unverified. @LaurenWags I presume your channel is still connected?

@Miyayes
Copy link
Collaborator

Miyayes commented Jun 10, 2022

Fallback on user ID sounds good to me. cc: @emerick

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Aug 4, 2022

The issue is not reproducible with current release component 1.0.174

Verified the STR with dev component using using --use-dev-goupdater-url and ensured rewards panel shows the correct creator publisher info for the Vimeo

Brave Local Data Updater - Version: 1.0.601

image


Verified using dev component for:

Brave Local Data Updater - Version: 1.0.601

Verified the STR with dev component using using --use-dev-goupdater-url and ensured rewards panel shows the expected creator info:

Screen Shot 2022-08-04 at 12 13 03 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment