Able to directly open a file instead of "downloading", like old Internet Explorer and current Microsoft Edge

[mailinglists35]

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[fmarier]

I created a test page for this.

In Edge, when you have the setting enabled (it's ON by default), then you get redirected to https://view.officeapps.live.com/op/view.aspx?src=https%3A%2F%2Ffmarier.org%2Funprotected%2Fbrave-homepage.docx&wdOrigin=BROWSELINK

This suggests that the feature only works for public files (the officeapps.com backend won't have the user's cookies for example) and it does mean that Microsoft could see the contents of the docs that are opened this way.

[mailinglists35]

this applies to linux as well. also macs. edge has the feature across all three major desktop os. vivaldi as well.

[mailinglists35]

I created a test page for this.

In Edge, when you have the setting enabled (it's ON by default), then you get redirected to https://view.officeapps.live.com/op/view.aspx?src=https%3A%2F%2Ffmarier.org%2Funprotected%2Fbrave-homepage.docx&wdOrigin=BROWSELINK

This suggests that the feature only works for public files (the officeapps.com backend won't have the user's cookies for example) and it does mean that Microsoft could see the contents of the docs that are opened this way.

you rushed to get the wrong conclusions. they do seem to try to send office-compatible files to their online viewer, but only for those file extensions. and even then they still show the download button at the top.

setup another test page with a non-office extension file and you'll notice you get the download/open dialog without a single network request to live.com

also the redirect to live.com only occurs on linux. on windows I am directly shown the open/save dialog without a single request to live.com.

[mailinglists35]

[mailinglists35]

the assumption about public/private files is also wrong, edge has no issues opening private cloud files without any request to live.com. not even for docx files in private cloud.

[mailinglists35]

@rebron

[fmarier]

Oh I see, you're asking for the dialog with both Open and Save buttons? Not the ability to open Office documents directly in the browser (using the cloud service)?

[mailinglists35]

Oh I see, you're asking for the dialog with both Open and Save buttons? Not the ability to open Office documents directly in the browser (using the cloud service)?

exactly.

this feature existed forever in IE, was available in firefox via addons, missing completely in google chrome since it's day 1, and eventually reimplemented by edge and vivaldi