Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adblock detected on this site #23550

Open
ghost opened this issue Jun 18, 2022 · 18 comments
Open

adblock detected on this site #23550

ghost opened this issue Jun 18, 2022 · 18 comments
Assignees
Labels
OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@ghost
Copy link

ghost commented Jun 18, 2022

Description

on this site the brave adblocking is detected:
https://maxstream.video/flw44cqfpwsm/WHBWU1l0eFoyQVRaRGlFelI5WjBHZz09

Steps to Reproduce

  1. just load the page with adblock enabled

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@ghost ghost added the OS/Desktop label Jun 18, 2022
@ryanbr
Copy link

ryanbr commented Jun 19, 2022

Unable to load site @dylantrevor87 Is there an updated url?

@ryanbr ryanbr self-assigned this Jun 19, 2022
@ryanbr ryanbr added the priority/P4 Planned work. We expect to get to it "soon". label Jun 19, 2022
@ryanbr
Copy link

ryanbr commented Jun 20, 2022

Okay the message is shown due to maxstream.video##+js(ra, style, div[style="display: none;"]) It should be working? cc: @antonok-edm

Related uBO filters:

filters/filters-2021.txt:maxstream.video##+js(ra, style, div[style="display: none;"])
filters/filters-2021.txt:maxstream.video##+js(nostif, height)
filters/filters-2021.txt:maxstream.video##+js(nowoif)
filters/filters-2021.txt:@@||maxstream.video^$script,1p
filters/filters-2021.txt:@@||maxstream.video^$ghide
filters/filters-2021.txt:maxstream.video##h1:has-text(/adblock|supporter/) 

@ghost
Copy link
Author

ghost commented Sep 13, 2022

Any news on this?
Currently I have added lots of custom block lists but I still see ads.

@ryanbr
Copy link

ryanbr commented Sep 14, 2022

Is there an updated url (the current reported link is dead) @dylantrevor87

@ghost
Copy link
Author

ghost commented Sep 14, 2022

try these:

https://maxstream.video/ivqjqov9jwjk/L3ZGOFo4QW9YUy83ZTNReEpkZ3Rydz09
https://maxstream.video/ivqjqov9jwjk/VkdFOWxnbnhlUjVMZWpTT1pMUEc0dz09
https://maxstream.video/icv6i9seqyax/VkdFOWxnbnhlUjVMZWpTT1pMUEc0dz09

(the ads don't show always, if they don't show up try reloading, or clear the cookies).

I tried blocking some ads with the picker (which by the way on this site sometimes the picker gets stuck and I have to close it, and reopen it).

Some ids I have blocked:
maxstream.video###container-9aab413bb15cdf136a593ce56f76fbf449251
maxstream.video###container-9aab413bb15cdf136a593ce56f76fbf438552
maxstream.video###container-9aab413bb15cdf136a593ce56f76fbf427077
maxstream.video###container-9aab413bb15cdf136a593ce56f76fbf427885
maxstream.video###container-9aab413bb15cdf136a593ce56f76fbf418775
maxstream.video###container-9aab413bb15cdf136a593ce56f76fbf465216
maxstream.video###container-9aab413bb15cdf136a593ce56f76fbf457399

But it seems useless: probably these ids are random generated.
These should be a different way to block these ads.

@ryanbr
Copy link

ryanbr commented Sep 14, 2022

Access denied Error code 1020
You cannot access maxstream.video. Refresh the page or contact the site owner to request access.

possibilty hard links are being blocked, none of them worked

@ghost
Copy link
Author

ghost commented Sep 14, 2022

try this:
https://uprot.net/msfld/ffgpwh979cu9

@ryanbr
Copy link

ryanbr commented Sep 15, 2022

Testing a fix, should land tomorrow.

@lazymonkey2
Copy link

thanks!

@ryanbr
Copy link

ryanbr commented Sep 15, 2022

Should be fixed now @424344 can you confirm?

@ghost
Copy link
Author

ghost commented Sep 16, 2022

No, it's still not fixed.
I'm seeing ads mainly in the lower right corner of the page, and sometimes in the center or top of the page.
I have taken a screenshot of the HTML (the ad is an iframe).
You can find the screen here:
https://ibb.co/y6tK3kX

@ghost
Copy link
Author

ghost commented Sep 16, 2022

Sorry, forget my previous comment.
While testing I had previously disabled Brave's adblocker, and forgot to enable it again.
If I enable it again the web site still detects the adblocker, shows an alert saying to disable the adblocker, and then hides the video player.

@ryanbr
Copy link

ryanbr commented Sep 16, 2022

It will still show the text, but the video plays fine here. (Clean profile, default shields)

https://gif.fanboy.co.nz/gif/maxstream.gif

@ghost
Copy link
Author

ghost commented Sep 16, 2022

please can you tell me what lists have you enabled?
and are you on stable release? I'm using v1.43.93.

I have just renamed my current brave profile, so on startup it was created a new one.
Did absolutely no changes to settings.

I loaded the uprot.net page, but had to disable shields on it, because the "continue" button wasn't shown.
this is strange because in your video you have shields enabled on uprot, and it works...

then I loaded maxstream, the player appears, but after some seconds the alert pops up (saying "disable your adblock please"), and it blocks the brave ui.
even if I don't click on the alert the player stops after some minutes.
and when I click it the player is hidden.

@ryanbr
Copy link

ryanbr commented Sep 19, 2022

Only Easylist Cookie enabled as an extra list, this has no affect on the site however. Try manually updating Brave Ad blocker in brave://components/ Ensure shields is up. Test in private window mode also (no extensions).
Video still plays here

@lazymonkey2
Copy link

I have just installed Brave beta, without changing options, but doesn't work like stable release.
I manually updated components. All is updated.
I also checked the adblock lists, and I have found enabled only "Easy List Italy".
Is it correct?
Only one list enabled by default?

@lazymonkey2
Copy link

found ths issue: I have preferred language set to italian, then english.

image

in this configuration the brave adblocker doesn't work, and the popup is showed after some seconds.

If I swap the languages, putting english at the top then the brave adblocker works, and the popup is not shown.

@lazymonkey2
Copy link

any news on fixing the issue without changing language?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

2 participants