Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] Memory degradation in v1.41.56 (cr103 update) #23698

Open
atuchin-m opened this issue Jun 27, 2022 · 2 comments
Open

[perf] Memory degradation in v1.41.56 (cr103 update) #23698

atuchin-m opened this issue Jun 27, 2022 · 2 comments
Assignees
Labels
OS/Desktop perf priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@atuchin-m
Copy link
Collaborator

https://brave-perf-dashboard.appspot.com/report?sid=4a087982db1a6c21095c971a6cbc2f8d5e583def592f588a90de6daf44a29d0d
brave/brave-core@v1.41.55...v1.41.56

The tricky thing is that we have a combination of two degradations:

  1. (Common with Chromium) Renderer processes start to consume more memory
  2. (Brave only) Other processes (=services) also start to consume extra memory.

Gpu/browser process memory isn't changed.

image

image

@atuchin-m atuchin-m self-assigned this Jun 27, 2022
@atuchin-m atuchin-m added this to To do in Perf via automation Jun 27, 2022
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 7, 2022
@atuchin-m
Copy link
Collaborator Author

  1. Problems 1 & 2 are the same thing. Dump analysis shows that all renderers start to consume extra memory. One of them is Brave Extension that is counted in unknown_process and it's the only reason why unknown_process metrics were changed. The consumption of other "unknown" processes was unchanged. Disabling Brave Extension confirms this theory.
  2. Perf run for Chrome shows that they also have a slightly anomaly: 33.3 MiB => 35.8 MiB.
  3. https://chromeperf.appspot.com/ shows a similar degradation in first May decade (it should be in cr103).
  4. Disabling testing_field_trials (a testing build-in Finch config) for perf run leads to more significant anomaly for Chrome: 24.7 MiB(!) => 30.4 MiB. This behavior is similar to Brave . And yep, disabling testing_field_trials surprisingly saves a lot of memory for Chrome.
  5. And what about production? Comparing beta 102.0.5005.40/103.0.5060.53 (with Finch enabled) show the same thing (see screenshots). The same thing for stable 103.0.5060.114 and for beta 104.0.5112.39.
  6. What exactly start to consume more memory in Chrome? Unfortunately, top level memory dump doesn't provide enough data (all metrics looks unchanged). Chrome chromeperf.appspot.com doesn't have enough precision to point to some commit range. So we need more deep investigation if we want to found a reason. IMHO better to file a ticket and ask chromium folks.

chrome_example_com

chrome_stable_103_about_blank

chrome_about_blank_anomaly

@rebron rebron added this to On Deck in General Jul 11, 2022
@atuchin-m
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop perf priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
General
  
On Deck
Perf
To do
Development

No branches or pull requests

2 participants