Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a user-friendly message OR hide icon in brave://settings/cookies when user clicks on trash-can icon for Allow all rule for site entry #24106

Open
MadhaviSeelam opened this issue Jul 18, 2022 · 1 comment
Assignees
Labels
feature/cookies feature/shields/cookies Cookie controls implemented as part of Shields. needs-investigation A bug not 100% confirmed/fixed OS/Desktop
Projects

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 18, 2022

Description

Currently when shields are down, the site is added to Allow all rule and can't be removed when clicked on trash icon next to the entry which is intentional. Providing a user-friendly message OR hide the trash icon, will address the original issue - #8604

Steps to Reproduce

  1. Install 1.42.62
  2. launch Brave
  3. Load www.whatismybrowser.com site
  4. Turn Shields DOWN
  5. Open brave://settings/cookies
  6. www.whatismybrowser.com is listed in Sites that can always use cookies
  7. Click trash-can icon next to it

Actual result:

Nothing happens

2022-07-18_08h58_22

Expected result:

Provide a user-friendly error message OR hide trash-can icon.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.42.62 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Windows 11 Version 21H2 (Build 22000.795)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @brave/qa-team
@MadhaviSeelam MadhaviSeelam changed the title Provide a user-friendly message OR hide icon in brave://settings/cookies when user clicks on trash-can icon for allow all site entry Provide a user-friendly message OR hide icon in brave://settings/cookies when user clicks on trash-can icon for Allow all rule for site entry Jul 18, 2022
@MadhaviSeelam MadhaviSeelam added feature/cookies feature/shields/cookies Cookie controls implemented as part of Shields. labels Jul 18, 2022
@urbenlegend
Copy link

I suggest instead of providing a message or hiding the icon, Brave should just re-enable shields for that particular site. Don't force users to have to navigate to the site again in order to delete it. It is also very useful to see a comprehensive list of all sites that have shields disabled and be able to manage it.

@rebron rebron added the needs-investigation A bug not 100% confirmed/fixed label Nov 22, 2022
@rebron rebron added this to In progress in General Nov 29, 2022
@rebron rebron moved this from In progress to On Deck in General Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/cookies feature/shields/cookies Cookie controls implemented as part of Shields. needs-investigation A bug not 100% confirmed/fixed OS/Desktop
Projects
Status: On Deck
General
  
On Deck
Development

No branches or pull requests

4 participants