Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not make requests to Rewards API endpoints when navigating to brave://rewards while not opted in to Rewards #25331

Closed
Miyayes opened this issue Sep 11, 2022 · 1 comment
Closed

Do not make requests to Rewards API endpoints when navigating to brave://rewards while not opted in to Rewards #25331

Miyayes opened this issue Sep 11, 2022 · 1 comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
Brave Rewards

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Sep 11, 2022 •
edited

Description

Currently, if a user is not opted in to Brave Rewards, if they navigate to brave://rewards (Rewards settings page), network requests are made to the Rewards API. If these network requests are not necessary, we should not make such requests.

image

Related: #14277 (comment)
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 11, 2022
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Sep 11, 2022
@Miyayes Miyayes changed the title Do not make request to Rewards API when navigating to brave://rewards while not opted in to Rewards Do not make requests to Rewards API endpoints when navigating to brave://rewards while not opted in to Rewards Sep 11, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Sep 12, 2022

After more discussion, closing in favor of #14277, which is more comprehensive.

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2022
Brave Rewards automation moved this from New Issues to Done Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
Brave Rewards
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Miyayes