Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing signing key hash on IPNS-shared content #25367

Open
stephendonner opened this issue Sep 13, 2022 · 1 comment
Open

Missing signing key hash on IPNS-shared content #25367

stephendonner opened this issue Sep 13, 2022 · 1 comment

Comments

@stephendonner
Copy link

Description

Missing signing key hash on IPNS-shared content

Steps to Reproduce

  1. install 1.45.41
  2. launch Brave
  3. load ipns://ipfs.io
  4. click Use a Brave local IPFS node
  5. open brave://settings/ipfs
  6. click on Set up your IPNS keys
  7. click Add
  8. type newKey (note its unique values)
  9. click Generate
  10. click on "hamburger menu" -> IPFS -> Update IPNS -> With a file
  11. share/pin any file using newKey

Actual result:

IPFS settings dweb.link link
ipfs-1 ipfs-2

look at the link; it's missing the newKey hash

e.g. https://dweb.link/ipfs/QmPwTDdLrziVkgUrjJ72kz8Gj2cV35GWkdnXHbu5PUyEtE?filename=sample3.txt

Also turns into https://bafybeiaxyyc3lrod5ocnxrwfkwz4htnrcehzck4ewsirc3r3spyspmvit4.ipfs.dweb.link/?filename=sample3.txt

Still missing the newKey hash.

Expected result:

Should have its newKey hash just before the ?filename= portion, according to my testcases.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.45.41 Chromium: 105.0.5195.102 (Official Build) nightly (64-bit)
Revision 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS Windows 10 Version 21H2 (Build 19044.1949)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @cypt4 @lidel @MadhaviSeelam

@srirambv
Copy link
Contributor

This is not just with new keys but also happens with existing self key as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
IPFS
  
Untriaged
Development

No branches or pull requests

3 participants