Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave News favicons should be HTTPS only #27285

Open
fmarier opened this issue Dec 9, 2022 · 2 comments
Open

Brave News favicons should be HTTPS only #27285

fmarier opened this issue Dec 9, 2022 · 2 comments
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude sec-low

Comments

@fmarier
Copy link
Member

fmarier commented Dec 9, 2022 •
edited

Let's add a check here:
https://github.com/brave/brave-core/blob/12c5397da8cfc0056e86bdcb6c1a22ec22b0d9f8/components/brave_today/browser/publishers_parsing.cc#L102

to only accept HTTPS URLs.
@fmarier fmarier added sec-low QA/No release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 9, 2022
@fmarier fmarier mentioned this issue Dec 9, 2022
Open
@fmarier
Copy link
Member Author

fmarier commented Dec 10, 2022

A few examples of URLs that should be rejected:

  • HTTP URLs: http://example.com/favicon.png
  • data: URIs: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAIAAACQkWg2AAABPUlEQVQoz6WSv6rCMBTGOymCIL6BizqIgvgHBRdxcPYJxNkHEDd1EhUclE6uPoKzu4OggoKP4CC3JqZNbJqbGKk3XVq4IcPJB7/DOV8+DdbrP6GQvEYk8kgm8WLBKFX0aBTkcni5ZIxp/M3cQyk9n2GthnVd0V8vejjAcpms13+A+53ZtqD2e5DPu7pzu/FGgtpsnq3WF4CNhtXviwpjIxZzdZDJ4NlMNDoeQamkAKjTkbUc3QXMdyN6OoFCIRBgDQZyVFip+APcAHq98oLoOmq3/YHPQQhWq9Zo5A/Y260wSu6QSgXbodd7ozb/2WAudbuu/g/g2Wzi8VhUpmnE48pIw6EMCA+V5nWDj7rbgWLxqyP0CRpfOptVAULk75DVyhvKy4XnF8/nmifeIJ3G0ylzHEUPhx+JBJ5MuFG/5/Ynabxw9yEAAAAASUVORK5CYII=
  • relative URLs: /favicon.ico

@mattmcalister
Copy link

Aggregator updated brave/news-aggregator#249

@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude sec-low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattmcalister @fmarier