Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translations on onboardingv2 #27475

Closed
btlechowski opened this issue Dec 20, 2022 · 1 comment
Closed

Missing translations on onboardingv2 #27475

btlechowski opened this issue Dec 20, 2022 · 1 comment
Labels
closed/works-for-me l10n onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.47.x - Release #4

Comments

@btlechowski
Copy link

btlechowski commented Dec 20, 2022 •
edited
Loading

Steps to Reproduce

  1. Clean profile
  2. Run Brave in PL Polish locale
  3. Open onboardingv2
  4. Click Pomiń
  5. Click Pomiń again

Actual result:

Some strings are not translated on Help make Brave better
image

Expected result:

All strings are translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.47.132 Chromium: 108.0.5359.128 (Official Build) beta (64-bit)
Revision 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS Ubuntu 18.04 LTS

cc @rebron @mkarolin @nullhook
@btlechowski btlechowski added l10n QA/Yes release-notes/exclude onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Dec 20, 2022
@rebron rebron added this to In progress in Front End Dec 21, 2022
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 22, 2022
@btlechowski
Copy link
Author

Verification passed on

Brave 1.47.177 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Ubuntu 18.04 LTS

Verified test plan from the description

image

@btlechowski btlechowski added this to the 1.47.x - Release #4 milestone Jan 19, 2023
@rebron rebron added closed/works-for-me and removed l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 19, 2023
@rebron rebron moved this from In progress to Completed in Front End Jan 19, 2023
@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 19, 2023
@rebron rebron removed this from Completed in Front End Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/works-for-me l10n onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.47.x - Release #4
Development

No branches or pull requests
2 participants
@rebron @btlechowski