Google doesn't show in autofill area when set as the phone's Autofill Service

[bsclifton]

Description

On Android phones, users can go to Settings > Autofill service and set Google as the default provider

They need to click the gear icon to pick which Google account and to enter the client side passphrase

Then, when on a webpage in Chrome - you can click the username or password field on forms and it'll let you pick which account / which saved password

Steps to reproduce

1. Go to settings
2. Search for Autofill service
3. Pick the option
4. Select Google as the default option (if it isn't already)
5. You should already have a Google account. Pick Google as the service
6. If you had 1Password installed, you may need to go to Settings > Accessibility > 1Password and turn off global registration. That seems to override everything
7. Visit a few sites in Chrome; add passwords
8. Go into Brave on those same sites
9. Click username or pw field

Actual result

Nothing shows in the context area that would usually show autofill items. The numbers show there since there are no registered provider

Expected result

It should work like Chrome

Issue reproduces how often

100%

Version/Channel Information:

Release channel, 1.46

[bsclifton]

It's not clear why this isn't showing. We may need the android.permission.BIND_AUTOFILL_SERVICE permission for this to work
See #24618 (which was created to have Brave show as an autofill service)

The only other change I can think of is that we had given up the QUERY_ALL_PACKAGES permission recently. Not sure if that is needed to detect autofill services?

[deeppandya]

@bsclifton QUERY_ALL_PACKAGES is used only to get all the applications on the device. so i don't think that could be the reason.

[abdulocracy]

I'm experiencing this issue with Android 13 and Bitwarden set as autofill provider.

[tjm00]

This was recently added to Vanadium.

[bsclifton]

+1 on Twitter: https://twitter.com/anil_makadia/status/1632368123792990211

[Vermill1on]

+1

[BrendanEich]

I think this came to me via another user, who DMed.

[deeppandya]

@BrendanEich we looked into the issue in the past.
basically, Google autofill service is not working with other chromium based browsers (edge, opera, vivaldi).
They have included autofill service in the google search app: https://play.google.com/store/apps/details?id=com.google.android.googlequicksearchbox not in chromium.
we need to add autofill service implementation on Brave app separately.
security review: https://github.com/brave/reviews/issues/1053 for more context.