Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank ads placeholders persists on Bhaskar.com #28439

Open
Cleveho opened this issue Feb 10, 2023 · 9 comments
Open

Blank ads placeholders persists on Bhaskar.com #28439

Cleveho opened this issue Feb 10, 2023 · 9 comments
Labels
features/shields/cosmetic-filtering OS/Desktop webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@Cleveho
Copy link

Cleveho commented Feb 10, 2023

Description

AdSense ads are blocked but the placeholder doesn't get removed/hidden even when setting blocking mode to "Aggressively block ads & trackers"

Steps to Reproduce

  1. Create a new profile & set shield blocking to Aggressive
  2. Visit bhaskar.com
  3. You can see ad placeholder at the top and right side

Actual result:

121

Expected result:

344

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.48.158 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 22H2 (Build 22621.1105)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? no
  • Is the issue reproducible on the latest version of Chrome? not applicable

Miscellaneous Information:

Some ads blocked using brave's block element :

www.bhaskar.com##.e307bc9e > .cf559a0e.f1ab6437
www.bhaskar.com###Ad--28928716--Bhaskar--Home--DAB_HP_BTF_300x250
www.bhaskar.com##div.cf559a0e.f1ab6437:nth-of-type(5)
www.bhaskar.com###Ad--28928716--Bhaskar--Home--DAB_HP_ATF_300x250
www.bhaskar.com##div.cf559a0e.f1ab6437:nth-of-type(2)
www.bhaskar.com##.cf2f6bd0.cf559a0e.f1ab6437

@Cleveho
Copy link
Author

Cleveho commented Feb 14, 2023

Can you fix this @ryanbr ?

@Cleveho
Copy link
Author

Cleveho commented Mar 10, 2023

Any update on this @ryanbr ?

@ryanbr
Copy link

ryanbr commented Mar 12, 2023

can you restart the browser @Cleveho and retest? ensure Indian list is enabled in brave://adblock

@Cleveho
Copy link
Author

Cleveho commented Mar 12, 2023

Not resolved, tested on new profile with default setting and Indian list enabled.

@ryanbr
Copy link

ryanbr commented Mar 12, 2023

Can you update to the latest ver of Brave?

@Cleveho
Copy link
Author

Cleveho commented Mar 12, 2023

@ryanbr
Copy link

ryanbr commented Mar 14, 2023

Can you force update the Indian list in brave://components. If that doesn't help re-test in Brave beta which is a completely seperate profile.

@peterlaws
Copy link

I'm seeing this with the new 1.56.9.... on dailymail especially

@bsclifton bsclifton added features/shields/cosmetic-filtering webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Jul 21, 2023
@bsclifton bsclifton added this to To do in Web Compatibility via automation Jul 21, 2023
@bsclifton
Copy link
Member

cc: @ryanbr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features/shields/cosmetic-filtering OS/Desktop webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
Development

No branches or pull requests

4 participants