Some Release's delta updates don't work on Windows

[mherrmann]

Description

Delta updates fail for some Windows releases. That is, Brave does get updated to the new version. But the small (10 MB) delta update file in this process fails and Brave falls back to downloading and running the full (100 MB) installer.

It does not happen for all versions:

• 1.47.186 -> 1.48.158 works
• 1.47.158 -> 1.48.164 works
• 1.47.164 -> 1.48.167 works
• 1.48.167 -> 1.48.171 works
• 1.48.171 -> 1.49.120 fails
• 1.49.120 -> 1.49.128 works
• 1.49.128 -> 1.49.132 works

This is for clean installs of the respective source version.

The associated log message in BraveUpdate.log is:

[Installer failed][C:\Program Files (x86)\BraveSoftware\Update\Install\{some GUID}\brave_installer-delta-x64.exe][][8]

When trying to go from 1.48.171 -> 1.49.120, %TMP%\chromium_installer.log says:

[0331/155625.200:ERROR:zucchini_apply.cc(166)] Invalid reference_delta
[0331/155625.200:ERROR:zucchini_integration.cc(139)] Fatal error encountered while applying patch.
[0331/155625.201:ERROR:archive_patch_helper.cc(106)] Failed to apply patch C:\Users\micha\Downloads\CR_481A5.tmp\setup_patch.diff to file C:\Program Files\BraveSoftware\Brave-Browser\Application\110.1.48.171\Installer\setup.exe and generating file C:\Users\micha\Downloads\CR_481A5.tmp\setup.exe using Zucchini. err=8
[0331/155625.201:ERROR:archive_patch_helper.cc(84)] Failed to apply patch C:\Users\micha\Downloads\CR_481A5.tmp\setup_patch.diff to file C:\Program Files\BraveSoftware\Brave-Browser\Application\110.1.48.171\Installer\setup.exe and generating file C:\Users\micha\Downloads\CR_481A5.tmp\setup.exe using Courgette. err=5
[0331/155625.202:ERROR:archive_patch_helper.cc(129)] Failed to apply patch C:\Users\micha\Downloads\CR_481A5.tmp\setup_patch.diff to file C:\Program Files\BraveSoftware\Brave-Browser\Application\110.1.48.171\Installer\setup.exe and generating file C:\Users\micha\Downloads\CR_481A5.tmp\setup.exe using bsdiff. err=8

Related issues

The following issue also affects delta updates on Windows: #29469

[GeetaSarvadnya]

@stephendonner I have seen somewhere you mentioned that the delta updaters are failing on windows. Is this the same issue?

[stephendonner]

@stephendonner I have seen somewhere you mentioned that the delta updaters are failing on windows. Is this the same issue?

@GeetaSarvadnya Yes, this was filed from my and others' experience (also Bondy's, lately): https://bravesoftware.slack.com/archives/C0112349LKB/p1679934332887839?thread_ts=1679849547.247489&cid=C0112349LKB

[kjozwiak]

Believe @LaurenWags also mentioned that she hasn't seen a delta on Win for a while now. They used to work pretty consistently but seem to regressed in the last few months.

[LaurenWags]

@kjozwiak is correct, I usually don't get them on Win 10 x86

[mherrmann]

I'm looking into this.

[LaurenWags]

@mherrmann not sure this will help, but here's what I saw yesterday when my delta failed. It seems to be basically what was noted in the description.

https://bravesoftware.slack.com/archives/C212VB0RG/p1680029538795329?thread_ts=1680029524.915709&cid=C212VB0RG

[mherrmann]

Thank you @LaurenWags. This appears to me to be the same, yes.

[mherrmann]

Related (but different) issue for non-Release channels: #29474.

[mherrmann]

I don't think this issue occurs any more. I tested the following delta updates:

• 114.1.52.130 -> 115.1.56.9
• 115.1.56.20 -> 116.1.57.47
• 116.1.57.47 -> 116.1.57.49
• 116.1.57.53 -> 116.1.57.57
• 116.1.57.57 -> 116.1.57.62
• 116.1.57.62 -> 116.1.57.64
• 117.1.58.127 -> 117.1.58.129
• 117.1.58.129 -> 117.1.58.131
• 117.1.58.131 -> 117.1.58.135
• 117.1.58.135 -> 117.1.58.137

They all worked without problem.

Because it no longer seems to occur, I am closing this (cc @mihaiplesa).