Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename brave_{wallet,news}/rust to rs #29220

Open
antonok-edm opened this issue Mar 21, 2023 · 0 comments
Open

Rename brave_{wallet,news}/rust to rs #29220

antonok-edm opened this issue Mar 21, 2023 · 0 comments

Comments

@antonok-edm
Copy link
Contributor

antonok-edm commented Mar 21, 2023

After some discussion, we've settled on a convention for structuring our bundled Rust code:

  • all Rust code is always located under an rs directory
  • if there are multiple related crates, there are subdirectories for each: i.e. cxx for cxx bindings, lib for the core implementation, wasm for wasm bindings
  • otherwise, the entire crate can go directly under rs without any subdirectories

brave_wallet and brave_news don't currently follow this convention; we should fix their paths. to improve consistency.

edit: Speedreader needs to be moved to use cxx, but in the meantime we can also rename its rust directory to rs instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant