Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: selected groups in tab bar stick with the group title #29259

Open
choyshaowei opened this issue Mar 23, 2023 · 2 comments
Open

UI: selected groups in tab bar stick with the group title #29259

choyshaowei opened this issue Mar 23, 2023 · 2 comments
Labels
design A design change, especially one which needs input from the design team OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon".
Projects
Front End

Comments

@choyshaowei
Copy link

Description

UI issues on the selected groups tabs are too close with the group title, check the screenshoots below.

Steps to Reproduce

  1. Create multiple group
  2. Add tabs into groups
  3. Click the tab next to the group title

Actual result:

image

Expected result:

Few pixels away from title, something like
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.49.120

Version/Channel Information:

Current release channel

  • Can you reproduce this issue with the current release?
    Yes
@rebron rebron added polish Nice to have — usually related to front-end/visual tasks design A design change, especially one which needs input from the design team priority/P4 Planned work. We expect to get to it "soon". labels Mar 23, 2023
@rebron rebron added this to P4 backlog in Front End Mar 29, 2023
@peize-li123
Copy link

Working on this!

@peize-li123
Copy link

Hi, I found the file to fix this bug but it's inside the chrome folder that was generated from npm init. I wasn't able to find the same file in brave-core folder. Does anyone know how I can submit my code change in this situation?

@peize-li123 peize-li123 mentioned this issue Apr 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon".
Projects
Front End
  
P4 backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebron @choyshaowei @peize-li123