Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting max balance in Swap/Send should remove the gas fee #29331

Open
HEagle18 opened this issue Mar 27, 2023 · 0 comments
Open

Selecting max balance in Swap/Send should remove the gas fee #29331

HEagle18 opened this issue Mar 27, 2023 · 0 comments
Assignees
@HEagle18
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include

Comments

@HEagle18
Copy link

Description

See conversation here -- > https://bravesoftware.slack.com/archives/CBP2ZKC0H/p1679759327891559

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (info found on brave://version)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@HEagle18 HEagle18 added feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Mar 27, 2023
@HEagle18 HEagle18 self-assigned this Mar 31, 2023
@HEagle18 HEagle18 added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Mar 31, 2023
@onyb onyb changed the title On sends, when selecting max balance it should remove the gas fee Selecting max balance in Swap/Send should remove the gas fee May 25, 2023
@onyb onyb mentioned this issue May 25, 2023
Merged
25 tasks
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HEagle18 HEagle18

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include
Projects
Web3
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onyb @HEagle18