Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When right-clicking then selecting the "search-brave-for" option on a text that has "oh!" at the beginning, Brave will search Open Hub for the following text or open open hub homepage if no following text was added. #29467

Open
dzyphr opened this issue Apr 3, 2023 · 3 comments

Comments

@dzyphr
Copy link

dzyphr commented Apr 3, 2023

Description

Discovered by trying to right-click brave search for Oh! Tengo Suerte . I Thought my search engine had been changed, but I realized open hub was an open source code platform not a generic search engine which confused me further.

Steps to Reproduce

  1. Select / Highlight the text Oh! Tengo Suerte or just Oh! or Oh! [followed by any text here]
  2. Right click the selection and choose Search Brave for Oh! [followup-text]

Actual result:

Open Hub webpage is displayed instead of users preferred search engine

Expected result:

Preferred search engine is used to search for the entire selected text.

Reproduces how often:

Everytime oh! is used. Seems like a hidden feature? But should absolutely be opt in and not mandatory

Brave version (brave://version info)

Brave 1.48.171 Chromium: 110.0.5481.177 (Official Build) (64-bit)
Revision f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS Linux
JavaScript V8 11.0.226.16
User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36
Command Line /opt/brave.com/brave/brave --disable-domain-reliability --enable-dom-distiller --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --variations-insecure-server-url=https://variations.brave.com/seed --flag-switches-begin --flag-switches-end --component-updater=url-source=https://go-updater.brave.com/extensions --desktop-startup-id=gnome-shell/
@trollboy
Copy link

This appears to be a bug in BraveSearch.com itself, as when I try searching with my search term there, regardless of browser. I just reproduced this using firefox on bravesearch.com.

@trollboy
Copy link

I was able to fix it by changing the brave default search to DuckDuckGo.

@esaulpaugh
Copy link

brave search still has this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants