Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Verified Publisher and Send a Tip not showing at all for a Brave Verified Publisher #3039

Closed
jfnasp opened this issue Jan 22, 2019 · 12 comments

Comments

@jfnasp
Copy link

jfnasp commented Jan 22, 2019

Description

Brave Verified Publisher icon and Send a Tip button do not show for a publisher that is a Brave Verified Publisher. (SpanishDict.com)

Seems to be similar to Issue #2816.

Steps to Reproduce

  1. Go to the site spanishdict.com
  2. Click on the orange triangle.
  3. Brave Verified Publisher icon and Send a Tip button never appears, even after waiting for a minute. On other sites, whether verified (vimeo.com) or unverified (google.com), it appears about every other time. The problem seems to be a timeout on checking the site on the Brave servers.

Actual result:

image

Expected result:

image

Reproduces how often:

Brave version (brave://version info)

Brave | 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Windows
JavaScript | V8 7.1.302.31
Flash | (Disabled)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? YES.
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

Note that after contacting Spanishdict, the problem is only on my end. They could not reproduce my problem.

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 22, 2019
@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Jan 22, 2019
@NejcZdovc NejcZdovc added the needs-investigation A bug not 100% confirmed/fixed label Jan 22, 2019
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to Need investigation/Suggestions in Rewards Jan 22, 2019
@jfnasp
Copy link
Author

jfnasp commented Jan 30, 2019

Now it is working, for some reason! (9 days later.) It appears as a verified publisher, and I can send a tip. Note that the date for my auto-contribute passed by (in which it said it had insufficient funds to contribute, which is untrue. So that bug continues.) But now I can send a tip. So perhaps it is tied to the auto-contribute date somehow, or perhaps it is tied to network time-out (faster today??). My guess is that it is tied to the network still. I will continue to update this entry if there are changes.

@mouradski
Copy link

my site appear to be verified under windows but not on Mac OS

@NejcZdovc
Copy link
Contributor

@mouradski did you just verified your site or was verified for few days now?

@mouradski
Copy link

@NejcZdovc about 3 days ago, but i tested other sites like vice.com with same issue

my site : https://www.2giga.link, as you can see it's verified under windows

@NejcZdovc
Copy link
Contributor

I see it as verified on macOS. This is not platform specific. It's how up to date is your publisher_list. Will checkout logic again, maybe there is something more to it. Thank you for the report

@mouradski
Copy link

thanx @NejcZdovc for your work

i added a screen

http://prntscr.com/mtxuo0

@mouradski
Copy link

i waited 48h and my site still not verified on mac

@bsclifton
Copy link
Member

cc: @atsyed87 RE: @mouradski above

@atsyed87
Copy link

i waited 48h and my site still not verified on mac

Sometimes the Rewards panel fails to download the list of verified publishers. You can force the browser to re-download the list.

Locate the “publishers_list” file in your Brave user files directory. I’ve added the path to each file, based on OS:

OSX: /Users/[You]/Library/Application Support/BraveSoftware/Brave-Browser-Development/Default

Windows: AppData/Local/ OR AppData/Roaming/ (look for a Brave folder; the file should be in there)

Linux: /.config/BraveSoftware/Brave-Browser-Development/Default

The publishers_list file will be in one of these folders. Close all instances of Brave, delete the publishers_list file, and reopen the browser. Your site should come up as verified.

@mouradski
Copy link

thanks for your answer @atsyed87

the publishers_list already contains my site ["2giga.link",true,false,{"channel_id":"de9c1c4f-aeb8-4ec5-b773-f2b8a0388235","title":"Brave Rewards","description":

i stopped brave instance and deleted file then launched brave browser, my site still not verified

Version 0.60.48 Chromium: 72.0.3626.121 (Build officiel) (64 bits)

publishers_list.txt

@NejcZdovc
Copy link
Contributor

deleting publisher list will not help. We are fixing this scenario here #3639

@NejcZdovc
Copy link
Contributor

closing as #3639 was merged

@NejcZdovc NejcZdovc added closed/not-actionable and removed needs-investigation A bug not 100% confirmed/fixed labels Apr 10, 2020
@NejcZdovc NejcZdovc removed this from Need investigation/Decision/Design in Rewards Apr 10, 2020
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Apr 10, 2020
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants