Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You're already sending a monthly contribution message doesn't have the indicator icon #30923

Closed
GeetaSarvadnya opened this issue Jun 8, 2023 · 1 comment
Labels
closed/wontfix OS/Android Fixes related to Android browser functionality

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #28149
You're already sending a monthly contribution message doesn't have the indicator icon

Steps to reproduce

  1. Clean profile 1.53.x
  2. Enable rewards and connect custodian
  3. Open laurenwags.github.io
  4. Set up a monthly contribution to this publisher
  5. Open the laurenwags.github.io panel and confirm that the monthly contribution is set
  6. Open the tipping banner
  7. You're already sending a monthly contribution message is displayed but the indicator icon is missing in the message

Actual result

image

Expected result

Desktop
image

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): All
  • Device type (Phone, Tablet, Phablet):All
  • Android version: 12

Brave version

1.53.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @Miyayes @deeppandya @sujitacharya2005

@sujitacharya2005
Copy link

@GeetaSarvadnya
This is expected.
All warning message will not show icon in mobile design. See this discussion in figma.

**The icon should only appear in the desktop version, since we have more space there.

In tablet and mobile, the icon doesn't appear.

It's not a general or universal rule, but more applies to this specific scenario of warnings inside this block.**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/wontfix OS/Android Fixes related to Android browser functionality
Projects
Brave Rewards
  
Done
Development

No branches or pull requests

2 participants