Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipping banner screens are not implemented as per the Android Tablet spec in both Portrait and landscape mode #30941

Closed
GeetaSarvadnya opened this issue Jun 9, 2023 · 2 comments
Labels
closed/invalid OS/Android Fixes related to Android browser functionality

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 9, 2023

Description

Found while testing #28149 (comment)
Tipping banner screens are not implemented as per the Android Tablet spec in both Portrait and landscape mode

Steps to reproduce

Issue 1:

  1. Clean profile 1.53.83
  2. Enable rewards and connect a uphold custodian
  3. Open laurenwags.github.io
  4. Open the tipping banner
  5. Tipping banners screens are not as per the spec

Issue 2:

  1. Clean profile 1.53.83
  2. Enable rewards and connect a uphold custodian
  3. Change the device orientation to landscape mode
  4. Open laurenwags.github.io
  5. Open the tipping banner
  6. Tipping banner doesn't open in the landscape mode
  7. Send a tip to a verified creator
  8. Success message is not shown in the landscape mode

Actual result

Tipping banner in Portrait mode

Example Example Example Example Example
Screenshot_20230609-183146_Brave - Beta Screenshot_20230609-183207_Brave - Beta Screenshot_20230609-183214_Brave - Beta Screenshot_20230609-183452_Brave - Beta image

Tipping banner in Landscape mode

Tweet message screen is from chrome hence it shows in Landscape mode all other images are in Portrait even though screen orientation is changed to Landscape

Example Example Example Example Example
Screenshot_20230609-183642_Brave - Beta Screenshot_20230609-183656_Brave - Beta Screenshot_20230609-183735_Brave - Beta Screenshot_20230609-183746_Brave - Beta image

Expected result

Spec - Android Tablet tipping banner screens in both Portrait and Landscape mode
image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet):Tablet
  • Android version: 12

Brave version

1.53.83

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @Miyayes @deeppandya @sujitacharya2005

@GeetaSarvadnya GeetaSarvadnya added feature/rewards QA/Yes QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality labels Jun 9, 2023
@GeetaSarvadnya GeetaSarvadnya added this to New Issues in Brave Rewards via automation Jun 9, 2023
@GeetaSarvadnya GeetaSarvadnya changed the title Tipping banner screens are not implemented as per the spec in Android Tablet for the Portrait or landscape mode Tipping banner screens are not implemented as per the Android Tablet spec in both Portrait and landscape mode Jun 9, 2023
@GeetaSarvadnya
Copy link
Author

Issue 3: Mouse hover on the creator icon displays the verified creator popup but there is a huge gap between the creator icon and the popup

Screenshot_20230609-191215_Brave - Beta

@GeetaSarvadnya
Copy link
Author

Closing the issue as these UI implementation will be taken care in #30371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/invalid OS/Android Fixes related to Android browser functionality
Projects
Brave Rewards
  
Done
Development

No branches or pull requests

1 participant