Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect estimated earnings for lower bound in an upgraded profile #31756

Closed
GeetaSarvadnya opened this issue Jul 20, 2023 · 4 comments
Closed
Assignees

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #30351

Incorrect estimated earnings lower bound in an upgraded profile

Steps to Reproduce

  1. Clean profile 1.53.100 production env
  2. Enable rewrads and select the Cayman Island from the country dropdown
  3. View a NTPSI (0.005 BAT)
  4. Connected prod uphold account
  5. View a regualr ad (0.01)
  6. Upgrade the profile to 1.57.x
  7. Confirmed that the estimated earnings range is as expected `0.008 - 0.015'
  8. View a regular ad in 1.57.x (0.05 BAT)
  9. Verify the estimated earnings range on the UI
  10. The max bound is as expected 0.065 BAT
  11. The lower bound is displayed as 0.048 which is not correct as the lower bound is multiplied by 0.8x for each regular ad and which comes around 0.016 BAT

Actual result:

Example Example
image image

Expected result:

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.57.18 Chromium: 115.0.5790.98 (Official Build) beta (64-bit)
Revision d515871a6c6df7d2843e755c8b7dda9b744f26d6
OS Windows 10 Version 22H2 (Build 19045.3208)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @Miyayes @zenparsing

@GeetaSarvadnya GeetaSarvadnya added this to New Issues in Brave Rewards via automation Jul 20, 2023
@GeetaSarvadnya GeetaSarvadnya changed the title Incorrect estimated earnings lower bound in an upgraded profile Incorrect estimated earnings for lower bound in an upgraded profile Jul 20, 2023
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jul 20, 2023

This issue appears in an grandfathered state also:

  1. Clean profile 1.47.119 beta build
  2. Enable rewards
  3. Confirmed that the estimated earnings is 0.000 BAT
  4. Upgrade the profile to 1.57.x
  5. Estimated earning is displayed as -- Learn more
  6. View an Ad
  7. Connect a custodian
  8. The estimated earnings range is displayed as 0.040 - 0.050 BAT
  9. The max bound value is displayed as expected 0.050 BAT
  10. The lower bound is 0.040 instead of 0.008
Example Example
image image

cc: @Miyayes @LaurenWags @zenparsing

@GeetaSarvadnya
Copy link
Author

The issue is reproducible on Android also Vivo x70 Pro version 12 running Bravemonoarm64.apk_1.57.19

For detailed steps please refer 1st case in Existing users

cc: @sujitacharya2005 @Miyayes @deeppandya

@GeetaSarvadnya GeetaSarvadnya added the OS/Android Fixes related to Android browser functionality label Jul 25, 2023
@GeetaSarvadnya
Copy link
Author

Looks like this is expected. I have asked a clarification to @Miyayes to confirm that same.

1st regular ad = 0.01 * 0.8 = 0.008
2nd regular ad= 0.05*0.8 = 0.04, so the lower bound value is (0.008 +0.04 = 0.048)

@GeetaSarvadnya
Copy link
Author

The issue works as expected hence closing the issue.

Brave Rewards automation moved this from New Issues to Done Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Brave Rewards
  
Done
Development

No branches or pull requests

2 participants