Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect lower bound value when a NTP SI + regular ad is viewed #31885

Closed
GeetaSarvadnya opened this issue Jul 26, 2023 · 2 comments
Closed
Assignees

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 26, 2023

Description

Found while testing #30352

Incorrect lower bound value when a NTP SI + regular ad is viewed

Steps to reproduce

  1. Clean profile 1.57.x enable rewrads and connect Cayman Island uphold production account
  2. View a NTPSI
  3. View a regular Ad
  4. Verify that the lower bound should be multiplied by 0.8x for the regular ad notification
  5. Confirmed that the lower bound is NOT multiplied by 0.8x for the NTPSI view
  6. Confirmed that NTP SI and Regular ad view earnings are combined in the max bound value hence the max bound value is 0.055 BAT (0.005 + 0.05 = 0.055 BAT)
  7. Verified that the estimated earning range 0.040 - 0.055 BAT is shown in the brave://rewrads and BR panel, the lower bound is displayed incorrect, the lower bound should be 0.008 instead of 0.040

Actual result

Example Example Example
Screenshot_20230726_163637 Screenshot_20230726_163642 Screenshot_20230726_163649

Logs:

2023-07-26 16:35:25.385 6866-6866/? V/chromium: [VERBOSE3:account.cc(248)] Successfully processed deposit for new_tab_page_ad with creative instance id 9165d3d8-f62e-4eb2-87a0-5f0f2bf3089d and view valued at 0.005

2023-07-26 16:36:03.989 6866-6866/? V/chromium: [VERBOSE3:account.cc(248)] Successfully processed deposit for ad_notification with creative instance id c83aa8f6-1da9-491f-be8f-e1453500c19a and view valued at 0.05

Expected result

The lower bound value should be 0.008 BAT

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?No

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet):all
  • Android version:12

Brave version

1.57.19

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @Miyayes @deeppandya @sujitacharya2005

@GeetaSarvadnya GeetaSarvadnya added this to New Issues in Brave Rewards via automation Jul 26, 2023
@stephendonner stephendonner changed the title Incorrect lower bound value when a NTP SI + regulat ad is viewed Incorrect lower bound value when a NTP SI + regular ad is viewed Jul 26, 2023
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 26, 2023
@Miyayes Miyayes moved this from New Issues to Backlog in Brave Rewards Jul 26, 2023
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jul 27, 2023

@deeppandya @sujitacharya2005 Looks like this is expected. I have asked a clarification to @Miyayes to confirm that same.

Lower bound value is 0.040 = (Regular ad earnings * 0.8 )

@GeetaSarvadnya
Copy link
Author

This issue works as expected hence closing the issue

Brave Rewards automation moved this from Backlog to Done Jul 27, 2023
@GeetaSarvadnya GeetaSarvadnya added closed/invalid and removed bug feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality labels Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Brave Rewards
  
Done
Development

No branches or pull requests

4 participants