Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AT Marketing tracking params to query filter #32488

Closed
fmarier opened this issue Aug 23, 2023 · 4 comments
Closed

Add AT Marketing tracking params to query filter #32488

fmarier opened this issue Aug 23, 2023 · 4 comments
Assignees
@fmarier
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Projects
Security & Privacy
Milestone
1.60.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Aug 23, 2023

Some of the parameters listed in https://developers.atinternet-solutions.com/as2-tagging-en/javascript-en/campaigns-javascript-en/marketing-campaigns-v2/ look like they are identifying specific users.
@fmarier fmarier added priority/P4 Planned work. We expect to get to it "soon". OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Aug 23, 2023
@fmarier fmarier self-assigned this Aug 23, 2023
@fmarier
Copy link
Member Author

fmarier commented Sep 21, 2023

These two look like they should be blocked:

  • at_recipient_id identifies a unique email address
  • at_recipient_list identifies an email list, which could be a list of 1

@fmarier fmarier added this to Untriaged Backlog in Security & Privacy via automation Sep 21, 2023
@fmarier fmarier moved this from Untriaged Backlog to In Progress in Security & Privacy Sep 21, 2023
@fmarier fmarier mentioned this issue Sep 22, 2023
Merged
25 tasks
@fmarier
Copy link
Member Author

fmarier commented Sep 22, 2023

Sample URLs:

Security & Privacy automation moved this from In Progress to Completed Sep 22, 2023
@fmarier fmarier added this to the 1.60.x - Nightly milestone Sep 22, 2023
@LaurenWags
Copy link
Member

Verified with

Brave | 1.60.81 Chromium: 118.0.5993.54 (Official Build) beta (x86_64)
-- | --
Revision | 1efb3f333eb41cc34af46ca31fb33c30e0afbfae
OS | macOS Version 13.6 (Build 22G120)

Reproduced using test plan from brave/brave-core#20254 (comment) and 1.58.x
Verified test plan from brave/brave-core#20254 (comment) and 1.60.x

1.58.x 1.60.x
1 58 1 60

@hffvld
Copy link
Contributor

hffvld commented Oct 24, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B1.230908.003 release-keys]
Brave build: 1.60.96 
Chromium: 118.0.5993.88 (Official Build) beta (64-bit) 
Revision: b4c059ad1d32d6e0cd1466123f03ccb97b3cf858

STEPS:

  1. Follow the steps from Add more query string parameters to our list brave-core#20254 (comment)

ACTUAL RESULTS:

  • Verified that the URL search bar contains only https://brave.com/
  • Verified the same by copy & paste the link and by opening the link from another app
1 2
1 2
2023-10-23_16-23-39.mp4

@LaurenWags LaurenWags mentioned this issue Nov 1, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Projects
Security & Privacy
  
Completed
Milestone
1.60.x - Release
Development

No branches or pull requests
3 participants
@fmarier @LaurenWags @hffvld