Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic twitch favicon displayed for verified twitch publisher #3330

Open
LaurenWags opened this issue Feb 12, 2019 · 5 comments
Open

generic twitch favicon displayed for verified twitch publisher #3330

LaurenWags opened this issue Feb 12, 2019 · 5 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #1521, #1814

First time you view a live stream of a twitch verified publisher, the auto contribute table, tips table, and panel will display the generic twitch icon instead of the publisher's favicon. Once you view a VOD for the verified pub, then you will see their specific favicon in ac table, tips table, and panel.

Steps to Reproduce

  1. Clean profile.
  2. Enable Rewards.
  3. Visit a verified publisher with a live stream in progress for min time needed (I was able to use https://www.twitch.tv/neoness007)
  4. Click on BAT logo to access panel or go to brave://rewards

Actual result:

Auto Contribute table, Tips Table, and Panel all show that the pub is verified but the generic twitch icon is used:
screen shot 2019-02-12 at 4 09 36 pm

screen shot 2019-02-12 at 4 08 58 pm

Expected result:

Was expecting the pub's specific favicon:
screen shot 2019-02-12 at 4 12 45 pm

screen shot 2019-02-12 at 4 13 01 pm

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.60.26 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Reproducible on current release: reproduces on ac table for current released 0.59.35

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @brave/legacy_qa @NejcZdovc

@btlechowski
Copy link

btlechowski commented Feb 13, 2019

The issue that I experienced was #3043.
To limit the confusion I edited this comment.

@NejcZdovc
Copy link
Contributor

@btlechowski this is track here #3043

@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Feb 14, 2019
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 14, 2019
@NejcZdovc NejcZdovc moved this from P1 & P2 Backlog to P3, P4, & P5 Backlog in Rewards Feb 14, 2019
@LaurenWags
Copy link
Member Author

Still reproducible, except now only the generic favicon is displayed, the verified publisher specific favicon is not shown at all.

Brave 0.71.51 Chromium: 76.0.3809.132 (Official Build) nightly (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

@GeetaSarvadnya
Copy link

The issue is reproducible in

Brave 0.72.3 Chromium: 76.0.3809.132 (Official Build) nightly (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

@NejcZdovc NejcZdovc added this to New issue in Rewards Media Publishers via automation Aug 27, 2020
@NejcZdovc NejcZdovc moved this from New issue to Twitch in Rewards Media Publishers Aug 27, 2020
@NejcZdovc NejcZdovc removed this from Icebox in Rewards Aug 27, 2020
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Jan 20, 2023
@Miyayes Miyayes added priority/P4 Planned work. We expect to get to it "soon". greaselion and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 20, 2023
@Miyayes
Copy link
Contributor

Miyayes commented Apr 5, 2023

Seems like it might still be an issue based on recent memory from Lauren. Should try to repro.

@Miyayes Miyayes moved this from New Issues to Backlog in Brave Rewards Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Brave Rewards
  
Backlog
Development

No branches or pull requests

6 participants