Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 117.0.5938.140 to Chromium 117.0.5938.153 #33391

Closed
emerick opened this issue Oct 3, 2023 · 8 comments
Closed

Upgrade from Chromium 117.0.5938.140 to Chromium 117.0.5938.153 #33391

emerick opened this issue Oct 3, 2023 · 8 comments
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.58.x - Release #7

Comments

@emerick
Copy link
Contributor

emerick commented Oct 3, 2023 •
edited

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/117.0.5938.140..117.0.5938.153?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Oct 3, 2023
@emerick emerick added this to the 1.58.x - Release #7 milestone Oct 3, 2023
@emerick emerick mentioned this issue Oct 3, 2023
Closed
25 tasks
@emerick emerick changed the title Upgrade from Chromium 117.0.5938.140 to Chromium 117.0.5938.149 Upgrade from Chromium 117.0.5938.140 to Chromium 117.0.5938.153 Oct 4, 2023
@emerick emerick mentioned this issue Oct 4, 2023
Merged
25 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2023

Closing as brave/brave-core#20382 was uplifted/merged into 1.58.x.

@kjozwiak kjozwiak closed this as completed Oct 4, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2023

The above needs 1.58.137 or higher for 1.58.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.58.137 Chromium: 117.0.5938.153 (Official Build) (64-bit)
-- | --
Revision | 40b532ccf3bc15f40c6165989b143955260b872c
OS | Windows 10 Version 22H2 (Build 19045.3448)

image

@LaurenWags
Copy link
Member

Verified with

Brave | 1.58.137 Chromium: 117.0.5938.153 (Official Build) (x86_64)
-- | --
Revision | 40b532ccf3bc15f40c6165989b143955260b872c
OS | macOS Version 13.6 (Build 22G120)
Intel

@btlechowski
Copy link

Verified PASSED

Brave 1.58.137 Chromium: 117.0.5938.153 (Official Build) (64-bit)
Revision 40b532ccf3bc15f40c6165989b143955260b872c
OS Linux

image

@LaurenWags
Copy link
Member

Verified with

Brave | 1.58.137 Chromium: 117.0.5938.153 (Official Build) (arm64)
-- | --
Revision | 40b532ccf3bc15f40c6165989b143955260b872c
OS | macOS Version 14.1 (Build 23B5046f)
Screenshot 2023-10-04 at 9 49 55 AM

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using version:

Brave	1.58.137 Chromium: 117.0.5938.153 (Official Build) (64-bit) 
Revision	40b532ccf3bc15f40c6165989b143955260b872c
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Version bump
  • Branding
Example Example
Screenshot 2023-10-04 at 11 09 33 AM Screenshot 2023-10-04 at 11 12 08 AM

@LaurenWags LaurenWags mentioned this issue Oct 4, 2023
Closed
@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.58.137 Chromium: 117.0.5938.153 (Official Build) (64-bit) 
Revision	40b532ccf3bc15f40c6165989b143955260b872c
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Version bump
  • Branding
Example Example
Screenshot 2023-10-04 at 12 30 51 PM Screenshot 2023-10-04 at 12 31 04 PM

@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.58.x - Release #7
Development

No branches or pull requests
7 participants
@kjozwiak @emerick @Uni-verse @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin