Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP Top sites/favorites platform parity #33845

Open
anthonypkeane opened this issue Oct 23, 2023 · 2 comments
Open

NTP Top sites/favorites platform parity #33845

anthonypkeane opened this issue Oct 23, 2023 · 2 comments
Assignees
@deeppandya @bradleyrichter
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality

Comments

@anthonypkeane
Copy link
Collaborator

anthonypkeane commented Oct 23, 2023 •
edited

Description

More info: https://bravesoftware.slack.com/archives/C02GELCD6BC/p1696121788822279

The scope of this issue is for V1 - detailed below. Subsequent versions should have a new GH issue.

Design: https://www.figma.com/file/MUhkPocM62cSGYkZ6CXVpT/Top-Sites---Cross-Platform-Suggestions?type=design&node-id=70%3A14712&mode=design&t=t2sESREz26fPX2cc-1
(Not complete, needs work for V1)

For v1, display a setting for either Favorites or Top Sites

Under DISPLAY > New Tab Page (potentially rename to Home Page) add the following
Keep the screen and setting as-is bar

Under
Widgets
Show Top Sites (On/Off)
Show Favorites (On/Off) (Greyed out unless Top Sites is off) --> Double check UX on this with Devs and Design

UI for adding Favorites
Need Design Help
@anthonypkeane anthonypkeane added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality labels Oct 23, 2023
@timchilds
Copy link
Collaborator

timchilds commented Dec 4, 2023 •
edited

Some extra details re: the functionality we should focus on for V1 MVP.

  1. Users can switch between Top Sites / Favorites in the NTP widget (new functionality).

  2. Users can add Favorites (to a top-level "Favorites" folder in bookmarks).

  • via the main menu when on a site (extend existing functionality).
  • via the widget (new functionality).
  1. Users can remove Favorites.
  • via a top-level "Favorites" folder in bookmarks (extend existing functionality).
  • via the widget (new functionality).
  1. Users can edit Favorites.
  • via a top-level "Favorites" folder in bookmarks (extend existing functionality).
  • via the widget (new functionality).
  1. Users can move Bookmarks in to Favorites.
  • via any bookmarks folder in bookmarks (extend existing functionality).
  1. Users can move Favorites in to Bookmarks.
  • via a top-level "Favorites" folder in bookmarks (extend existing functionality).
  1. The Favorites folder need to be localizable, as in the UK it will be spelt Favourites.

Try to re-use at much of the bookmarks functionality as possible for add, edit, remove Favorites.

cc @anthonypkeane @deeppandya

This was referenced Feb 28, 2024
Closed
Closed
Closed
@DarrenSem
Copy link

[ reminder to self and others: this is duplicate of a now-closed issue -- #17217 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

@bradleyrichter bradleyrichter

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@deeppandya @anthonypkeane @bradleyrichter @timchilds @DarrenSem