Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to close Leo if "show sidebar button" toggle is disabled #35935

Open
Brave-Matt opened this issue Feb 9, 2024 · 3 comments
Open

No way to close Leo if "show sidebar button" toggle is disabled #35935

Brave-Matt opened this issue Feb 9, 2024 · 3 comments
Labels
browser-ai feature/sidebar Relating to Brave's Sidebar feature feature/user-interface All UI related OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects

Comments

@Brave-Matt
Copy link

Description

If you have the sidebar button disabled (Settings --> Appearance ), when you go to Ask Leo in the address bar and ask it something, there’s then no way to close the sidebar panel. Your options are to close the tab entirely or to use the keyboard shortcut, which is not intuitive.

image

We should add x or “close” button somewhere on the Leo panel for cases like this. If we don't want to clutter the panel, I'd suggest putting the option in the "three dots" drop down menu:

image

Steps to Reproduce

  1. Disable "Show sidebar button" option in Settings --> Appearance
  2. Open a new tab (or any tab) and enter a term in the address bar, select Ask Leo option
  3. When Leo panel opens, observe that there is no way to close the panel without closing the tab or knowing the keyboard shortcut.

Reproduces how often:

Always

Brave version (brave://version info)

v1.62.156 and higher

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@Brave-Matt Brave-Matt added feature/user-interface All UI related OS/Desktop feature/sidebar Relating to Brave's Sidebar feature browser-ai labels Feb 9, 2024
@aguscruiz
Copy link

aguscruiz commented Feb 12, 2024

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Feb 12, 2024
@rebron rebron added this to On Deck in Front End Feb 13, 2024
@Kchecksfiles
Copy link

UPDATE: feature not yet rolled out in official build. [Version 1.63.174 Chromium: 122.0.6261.128]

@DeveloperAlly
Copy link

DeveloperAlly commented May 27, 2024

This is the absolutely worst UI.

I am completely removing because of this issue.

I have no idea who thought it was ok not to have a close button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-ai feature/sidebar Relating to Brave's Sidebar feature feature/user-interface All UI related OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include
Projects
Front End
  
On Deck
Development

No branches or pull requests

5 participants