Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News]: Publisher list in side panel collapses after adding/updating publishers/channels #36550

Open
Tracked by #35960
LorenzoMinto opened this issue Mar 5, 2024 · 6 comments
Open
Tracked by #35960

[Brave News]: Publisher list in side panel collapses after adding/updating publishers/channels #36550

LorenzoMinto opened this issue Mar 5, 2024 · 6 comments
Labels
feature/brave-news formerly brave-today good first issue OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude

Comments

@LorenzoMinto
Copy link
Member

LorenzoMinto commented Mar 5, 2024 •
edited

  • Open Brave News
  • Click + in the side panel headers or Customise button on the bottom right
  • Add publisher/channel

Unexpected behaviour: Navigation panel sections should not collapse when something is added/removed. See in screenshot how Channels section has collapsed.

Screen Shot 2024-05-23 at 11 38 56 AM
@LorenzoMinto LorenzoMinto added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude OS/Desktop feature/brave-news formerly brave-today labels Mar 5, 2024
@LorenzoMinto LorenzoMinto changed the title Publisher list in side panel collapses after adding/updating pubslishers/channels Publisher list in side panel collapses after adding/updating publishers/channels Mar 5, 2024
@LorenzoMinto LorenzoMinto mentioned this issue Mar 8, 2024
Open
@LorenzoMinto LorenzoMinto changed the title Publisher list in side panel collapses after adding/updating publishers/channels [Brave News]: Publisher list in side panel collapses after adding/updating publishers/channels Mar 19, 2024
@TevinWang
Copy link

TevinWang commented Apr 10, 2024 •
edited

Hi @LorenzoMinto I'm happy to take this on as the first contribution! Reproduced on my own browser.

@LorenzoMinto
Copy link
Member Author

Hey @TevinWang! That would be awesome. Let me know if you have any questions 👍

@Hamza-H10
Copy link

hi, I have tried to reproduce this but seem like this working fine, i noticed that to some channel we need to click twice to add it in the list. please provide clarity if this is resolved or not ?

@scottish3dprinter
Copy link

I could not reproduce this issue what os are you on?

@shreyaslax
Copy link

Hi @LorenzoMinto I'm happy to take this on as the first contribution.

@LorenzoMinto
Copy link
Member Author

This issue is still open and any contribution is welcome. Please open a PR and me or someone in the team will review. @scottish3dprinter I'm on OSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/brave-news formerly brave-today good first issue OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@LorenzoMinto @TevinWang @shreyaslax @scottish3dprinter @Hamza-H10