Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few strings (such as Quick commands & Speedreader) are not translated in #36934

Open
MadhaviSeelam opened this issue Mar 19, 2024 · 0 comments
Open
Labels
bug l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes
Projects

Comments

@MadhaviSeelam
Copy link

Description

Found while testing #36899. Quick commands were translated in 1.63.x but not in 1.64.x. However Speedreader is not translated in either 1.63.x or 1.64.x

Steps to Reproduce

  1. Set OS locale to German/Japanese/Espanol (Argentina)/Portuguese(Brasil)
  2. Clean profile 1.64.108
  3. Open brave://settings/appearance
  4. Open hamburger>>More tools>>

Actual result:

Speedreader is not translated
Quick commands is not translated

Portuguese

1.63.x 1.64.x
image image
Japanese - 1.64.x German - 1.64.x Espanol - 1.64.x
image image image

Expected result:

strings should be translated in above mentioned locales

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.64.108 Chromium: 123.0.6312.46 (Official Build) (64-bit)
-- | --
Revision | be7ad9d53800b7f5380fea097ff30bf628f157b0
OS | Windows 11 Version 23H2 (Build 22631.3296)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@mkarolin @rebron
cc: @brave/qa-team

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 22, 2024
@rebron rebron added this to On Deck in General Mar 22, 2024
@rebron rebron moved this from On Deck to P1 & P2 Backlog in General Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes
Projects
General
  
P1 & P2 Backlog
Development

No branches or pull requests

2 participants