Split view MVP tasks

[sangwoo108]

https://www.figma.com/file/uiDbQ0ocpqiraWEeQVUyId/Tabs---Vertical-%2F-Split-%2F-Sidebar?type=design&node-id=35%3A6412&mode=dev

Tasks

Beta Give feedback

1. Make flag to enable split view
2. Tab group should be considered
3. Drag and drop should work for both tabs.
4. Make data structure to manage split view data #37088
   OS/Desktop QA/No priority/P3 release-notes/exclude +4
   
5. Make context menu item to tile two tabs in split view / unset tiled views
6. BrowserView::GetAccessiblePane
7. Make secondary web view to support SplitView #37231
   OS/Desktop QA/No priority/P3 release-notes/exclude +4
   
8. Draw bounding rects for split view tiles #37274
   QA/No priority/P3 release-notes/exclude +3
   
9. Adjust split view tile layout in vertical tab #37539
   OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
   
10. Devtools for secondary web view is not visible #37413
    OS/Desktop QA/No priority/P3 release-notes/exclude +4
    
11. Open link test
12. Tabs created from split view is located between tiled tabs #37326
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
13. Break tiles when moved tabs are between tiles #37328
    OS/Desktop QA/No priority/P3 release-notes/exclude +4
    
14. Split view crashes when switching tabs orientation #37408
    OS/Desktop QA/No priority/P3 release-notes/exclude +4
    
15. Replace weakptr with raw_ptr in OnTabDragEndedClosure #37576
    OS/Desktop QA/No dev-concern release-notes/exclude +4
    
16. Replace base::FeatureList::IsEnabled(kSplitView) with SplitViewBrowserData::FromBrowser() if possible #37577
    OS/Desktop QA/No priority/P3 release-notes/exclude +4
    
17. Activate tab in secondary web view when it's focused #37677
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
18. Synchronize grouped state on tiling two tabs #37717
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
19. Dragging a tab in a tile should move the other tab paired move together #37678
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
20. Update split view tile design in vertical tab mode #37712
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
21. Synchronize pinned state on tiling tabs #37761
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
22. Make test for case where tile breaks after moving tabs Break tile when moved tabs are between tiles brave-core#22933 (comment)
23. Blank tab behavior - Brave crashes with Split View flag enabled when getting a popup window. #37447 (comment)
24. When there're multiple pinned tabs, opening split view for a pinned tab tiles wrong tab #37803
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
25. Draw border for contents web views in split view mode #37804
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
26. Rename tab context menu label break into tabs => Unsplit tabs #37850
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
27. Remove 'Close SplitView' tab context menu item #37851
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
28. SplitView's Tile should be kept after detaching into new window #37852
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
29. Update SplitView tile background color #37919
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
30. Update secondary web view and focus border's radius #37924
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
31. Hide the Splitview flag in Release channel #38302
    OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude split view +5
    
32. Resize handle for split view #38356
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
33. Resized amount for split view tile should be kept per tile #38392
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
34. Add Menu button to split view separator #38584
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    
35. Add "Swap Split view position" #38656
    OS/Desktop QA/No priority/P3 release-notes/exclude split view +5
    

TBD / Follow-ups

Beta Give feedback

1. location bar
2. Can we alleviate flickering when switching tabs? maybe fast resize flag?
3. Focuses wrong ui component - Brave crashes with Split View flag enabled when getting a popup window. #37447 (comment) - may not be problem
4. Video fullscreen doesn't work well
5. Tile should be persistent even after restart
6. Reverse function - flip the first and second
7. Add "Open in split view" render context menu
8. 3+ split view
9. Need menu button in the gap between split views

[bridiver]

Similar to the follow up issue we should include more content here rather than just linking to Figma. This is currently completely opaque to anyone outside of Brave and I don't even know if everyone inside of Brave already has a Figma login or not.

[sangwoo108]

I intentionally left figma link just in case. Asked @aguscruiz if it's okay to open our design public.

[aguscruiz]

Hi. This would probably be solved if we just add more screenshots to issues, right?

I try to add them sparingly because the problem with them is that they get outdated as soon as I make a tiny change. That's why I prefer figma links.

Regarding Figma access, everyone who has a @brave.com email has access to all of our Figma environment, so that shouldn't be a problem.

[bridiver]

I try to add them sparingly because the problem with them is that they get outdated as soon as I make a tiny change. That's why I prefer figma links.

I think that actually makes the problem here worse because this PR represents a snapshot in time, but figma is changing. That makes it particularly difficult to come back to changes in the future to see what they were supposed to do. Remember that these issues attached to PRs are not just about what we need to do right now, they are a record of what we did and why for the future.