Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux desktop file refers to "Incognito" windows #37623

Open
rillian opened this issue Apr 16, 2024 · 3 comments
Open

Linux desktop file refers to "Incognito" windows #37623

rillian opened this issue Apr 16, 2024 · 3 comments
Labels
good first issue OS/Desktop OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@rillian
Copy link

rillian commented Apr 16, 2024

Description

Our brave-browser.deskop file, included with the official Linux packages, refers to brave --incognito as "New Incognito Window". This should use our "New Private Window" terminology.

Brave version (brave://version info)

1.64.122

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Miscellaneous Information:

Afaict gnome desktops don't use this information, but it's used by several of the older launchers.

@fmarier fmarier added good first issue priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Apr 16, 2024
@Pushkal-G
Copy link

Pushkal-G commented Apr 18, 2024

Hey @fmarier , This is pretty handy browser , going through the repo. Pretty interesting, eager to work on something.Should I start working on this, or if there are some other work you can suggest , thats good too.

@MartiPresa
Copy link

Hi, is this issue still available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue OS/Desktop OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

4 participants