Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocking scripts disables adblock scriptlet injections #38065

Open
nihil-admirari opened this issue May 4, 2024 · 2 comments
Open

Blocking scripts disables adblock scriptlet injections #38065

nihil-admirari opened this issue May 4, 2024 · 2 comments
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. privacy uBO-parity

Comments

@nihil-admirari
Copy link

I've recently discovered that Brave fails to prevent click tracking on DuckDuckGo. After searching for similar issues, it turned out that (emphasis mine):

It could either be fixed if we added DDG to the debounce list (as you pointed out), or if we supported the href-sanitizer scriptlet properly (the topic of the original issue you filed).

I've no idea how many other features of uBlock Origin are actually not supported (doesn't look like the list of unsupported functionality is documented anywhere).

Currently the user is basically forced to install an additional 3rd-party adblocker, since the built-in one is subpar.

@antonok-edm
Copy link
Contributor

I just went through the steps you posted in brave/adblock-resources#167 - looks like this is actually related to having scripts disabled.

If you do a search on html.duckduckgo.com without blocking scripts, the links are fixed as expected.

It sort of makes sense since href-sanitizer itself is a script - but it's probably not what anyone expects. We'll see what we can do. Thanks for reporting, @nihil-admirari!

@antonok-edm antonok-edm changed the title Built-in adblocker must have feature parity with uBlock Origin Blocking scripts disables adblock scriptlet injections May 6, 2024
@ShivanKaul
Copy link
Collaborator

doesn't look like the list of unsupported functionality is documented anywhere

If you filter GitHub issues by uBO-parity like this, that should cover what we currently want to support but just haven't gotten around to yet.

@ShivanKaul ShivanKaul added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. privacy uBO-parity
Projects
None yet
Development

No branches or pull requests

3 participants