Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split npm run sync/build responsibilities on branding/localization files update #38309

Open
goodov opened this issue May 14, 2024 · 0 comments
Open

Comments

@goodov
Copy link
Member

goodov commented May 14, 2024

Right now we copy localization and branding files on top of Chromium during npm run build command. We do this, because some things are channel-dependent. This is not great as it:

  • adds a persistent delay to each npm run build command
  • doesn't allow deterministic workspace caching after npm run sync, because npm run build may rewrite some files in src/*.

On Teamcity we archive the workspace in parallel with npm run build, which may lead to invalid files being stored in cache.

The plan to fix this:

  • make all src/* modifications during applyPatches call, which is called as a part of npm run sync and also can be triggered manually as npm run apply_patches.
  • implement channel-specific modification via GN.

If things turns out to be hard to wire via GN, another option is to support --channel in sync command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant