Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block Solana AddUnapprovedTransaction with fee estimation RPCs #39025

Open
6 tasks
yrliou opened this issue Jun 13, 2024 · 0 comments
Open
6 tasks

Don't block Solana AddUnapprovedTransaction with fee estimation RPCs #39025

yrliou opened this issue Jun 13, 2024 · 0 comments
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@yrliou
Copy link
Member

yrliou commented Jun 13, 2024

Description

After brave/brave-core#23214, we blocked Solana AddUnapprovedTransaction with fee estimation RPCs.
When RPCs are very slow, users won't see anything because we only popup the panel after AddUnapprovedTransaction is done.
We should consider change this to first add the unapproved transaction without waiting, and fire an transaction changed event to frontend once fee estimation is ready.

Steps to reproduce

  1. create a Solana send transaction with slow network

Actual result

transaction approval screen won't show up after quite a while

Expected result

transaction approval screen should show up in a timely manner

Reproduces how often

Easily reproduced

Desktop Brave version (brave://version info)

nightly

Android device

All

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@yrliou yrliou added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 13, 2024
@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/solana labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant