Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CR127] keystone_glue.mm is using banned methods #39174

Open
emerick opened this issue Jun 19, 2024 · 0 comments
Open

[CR127] keystone_glue.mm is using banned methods #39174

emerick opened this issue Jun 19, 2024 · 0 comments
Labels
Chromium/Followup Followup work logged during Chromium rebase dev-concern

Comments

@emerick
Copy link
Contributor

emerick commented Jun 19, 2024

Description

@bridiver mentioned that browser/mac/keystone_glue.mm is using banned methods (such as from NSFileManager) and it's happening on the UI thread. We should update this code to fix that, being careful not to affect its ability to handle updates.
@emerick emerick added dev-concern Chromium/Followup Followup work logged during Chromium rebase labels Jun 19, 2024
@emerick emerick changed the title keystone_glue.mm is using banned methods [CR127] keystone_glue.mm is using banned methods Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Chromium/Followup Followup work logged during Chromium rebase dev-concern
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emerick