Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up to #38340] Add Bookmark for <X> Tabs button shows wrong count when NTP is opened in background #39590

Open
3 of 5 tasks
hffvld opened this issue Jul 5, 2024 · 0 comments
Labels
bug feature/bookmarks OS/iOS Fixes related to iOS browser functionality QA/Yes

Comments

@hffvld
Copy link
Contributor

hffvld commented Jul 5, 2024

Description

Follow-up to #38340.

Steps to reproduce

  1. Launch Brave
  2. Open any 2 websites
  3. Open 3 NTP > While on NTP tap and hold the Tab switch button > Confirm there is no Add Bookmark for <X> Tabs button
  4. Keep NTP opened and switch to another tab with a random website opened
  5. Tap and hold the Tab switch button > Tap Add Bookmark for 5 Tabs > Save
  6. Open Bookmarks > Saved Tabs folder > Observe that only 2 tabs are saved

2024-07-05_11-10-37.mp4

Actual result

The Add Bookmark for <X> Tabs button shows the wrong count when NTP is opened in the background.

Expected result

The correct number of tabs must be shown in the Add Bookmark for <X> Tabs button.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.68 (110)
BraveCore: 1.68.110 (127.0.6533.26)

Device/iOS version

iPhone 14 / iOS 17.6

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/bookmarks OS/iOS Fixes related to iOS browser functionality QA/Yes
Projects
None yet
Development

No branches or pull requests

1 participant