Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quality of verified domain 3p checking #4029

Open
bbondy opened this issue Apr 5, 2019 · 1 comment
Open

Improve quality of verified domain 3p checking #4029

bbondy opened this issue Apr 5, 2019 · 1 comment
Labels
feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon".
Projects

Comments

@bbondy
Copy link
Member

bbondy commented Apr 5, 2019

Description

Associate some domains with others for our shields 3p checking.

Example:
ksandbox.org and www.khanacademy.org

https://twitter.com/pamelafox/status/1114210142893953024

Currently checks are done via SameDomainOrHost

Steps to Reproduce

  1. Go to https://www.khanacademy.org/computer-programming/new/pjs
  2. Type in some code
  3. Hit save

Actual result:

Error happens because of device recognition blocking

Expected result:

Should work

Reproduces how often:

Always

Brave version (brave://version info)

All, tested on 0.64.36

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? yes
  • Is the issue reproducible on the latest version of Chrome? no
@bbondy bbondy self-assigned this Apr 5, 2019
@fmarier
Copy link
Member

fmarier commented Apr 5, 2019

That domain isn't in the Mozilla list I mentioned in #3194 so if we were to start with that list, we would likely need to fork it or supplement it with a Brave-specific list.

@rebron rebron added the feature/shields The overall Shields feature in Brave. label Apr 12, 2019
@rebron rebron added this to Untriaged / Incoming in Shields via automation Apr 12, 2019
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Apr 12, 2019
@bbondy bbondy removed their assignment Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon".
Projects
Shields
  
Untriaged / Incoming
Development

No branches or pull requests

3 participants