Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global script blocking with Private window with Tor does not work #4191

Closed
ghost opened this issue Apr 22, 2019 · 4 comments
Closed

Global script blocking with Private window with Tor does not work #4191

ghost opened this issue Apr 22, 2019 · 4 comments
Labels
feature/shields/!scripts Blocking JavaScript with Shields feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@ghost
Copy link

ghost commented Apr 22, 2019

Description

When in Private Tor browser script blocking preferences do not work.

Steps to Reproduce

  1. Open Private window with Tor
  2. Go to settings by clicking the hamburger in the top right corner.
  3. Toggle the switch to enable script blocking.

Actual result:

Scripts are still enabled.

Expected result:

Scripts should be disabled.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 0.62.51 Chromium: 73.0.3683.103 (Official Build) (64-bit)

@bsclifton bsclifton added feature/shields/!scripts Blocking JavaScript with Shields feature/tor labels Apr 22, 2019
@rebron rebron added this to Untriaged in Tor and Private Windows via automation Apr 26, 2019
@riastradh-brave riastradh-brave added the feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. label May 6, 2019
@riastradh-brave riastradh-brave moved this from Untriaged to Guest Semantics in Tor and Private Windows May 6, 2019
@Brave-Matt
Copy link
Collaborator

+1 from Reddit:
https://www.reddit.com/r/brave_browser/comments/bpchn5/brave_with_tor_and_scripts/

@ghost
Copy link

ghost commented Jun 27, 2019

This is pretty important IMHO and could cause a lot of trouble if someone without knowledge of this bug gets screwed over trying to use Tor through Brave.

@yrliou
Copy link
Member

yrliou commented Oct 3, 2019

This should be fixed now with brave/brave-core#3319 merged.

@yrliou yrliou closed this as completed Oct 3, 2019
Tor and Private Windows automation moved this from Guest Semantics to Completed Oct 3, 2019
@yrliou yrliou added this to the 0.72.x - Nightly milestone Oct 3, 2019
@yrliou yrliou added the QA/Yes label Oct 3, 2019
@btlechowski
Copy link
Collaborator

btlechowski commented Oct 28, 2019

Verification passed on

Brave 0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Verified test plan from brave/brave-core#3319
Verified bookmarks and global settings are shared between normal and tor window.
Verified that brave://settings page is redirected to normal window.

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description
  • Verified test plan from Tor profile rework brave-core#3319
  • Verified bookmarks and global settings are shared between normal and tor window.
  • Verified that brave://settings page is redirected to normal window.

Verified passed with

Brave 1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified test plan from the description
  • Verified test plan from Tor profile rework brave-core#3319
  • Verified bookmarks and global settings are shared between normal and tor window.
  • Verified that brave://settings page is redirected to normal window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/!scripts Blocking JavaScript with Shields feature/tor/guest-semantics Exposing the fact that private windows with Tor are built on guest sessions. feature/tor QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Development

No branches or pull requests

7 participants