Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximize and minimize window options not required in Add IPFS companion popup #4297

Closed
GeetaSarvadnya opened this issue May 3, 2019 · 1 comment

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 3, 2019

Description

Found while testing #4218

Maximize and minimize window options not required in Add IPFS companion popup. Maximize option is causing buttons disapper ( Cancel and Add extension ) from Add IPFS companion popup

Steps to Reproduce

  1. Clean profile 0.64.68
  2. Navigate to brave://settings
  3. Search for IPFS and toggle the IPFS Companion switch to ON
  4. Click on + or maximize option in Add IPFS companion popup

Actual result:

Buttons Cancel and Add extension disappers from Add IPFS companion popup

image
IPFS extension install popup issue_Linux

Expected result:

Maximize and minimize window options needs to removed from Add IPFS companion popup

image

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.64.68 Chromium: 74.0.3729.108 (Official Build) beta (64-bit)
Revision daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

@brave/legacy_qa

@rebron
Copy link
Collaborator

rebron commented May 7, 2019

Closing. Works as expected, current linux behavior for windows.

@rebron rebron closed this as completed May 7, 2019
General automation moved this from Untriaged Backlog to Completed May 7, 2019
@kjozwiak kjozwiak removed this from Completed in General May 7, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants