Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_api_features.json content is duplicated from upstream, not modified #5491

Open
petemill opened this issue Aug 1, 2019 · 0 comments
Open

Comments

@petemill
Copy link
Member

petemill commented Aug 1, 2019

In https://github.com/brave/brave-core/blob/v0.70.25/common/extensions/api/_api_features.json (and associated manifest and permissions json file), we're copy / pasting the content from chromium and adding Brave changes to it.

Whilst this was seen as beneficial over patching from a rebasing point of view, it can lead to not picking up upstream modifications to API permissions for various contexts. This can lead to browser breakage, web/extension-compat issues and security deviations.

Instead, we could either:

  • Merge our json properties with chromium's json properties
  • Or, run a script to modify (allows deleting items)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants